-
Notifications
You must be signed in to change notification settings - Fork 110
[JENKINS-75569] Upgrade Stapler from EE 9 to EE 10 #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
60a73e2 to
caba568
Compare
ef2372c to
b8e5b17
Compare
043dc9e to
1427dd1
Compare
|
I understand this needs jelly pull request merged and release first, but there are a few |
|
These obscure corners of the API are extremely unlikely to be used in practice, and implementing them would be a lot of work—certainly more work than the easier (and better long-term option) path of migrating from EE 8 to EE 9/10. A similar strategy was used for the Acegi migration, which left some obscure corners of the API unimplemented under the assumption that nobody would ever need compatibility for them. |
olamy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
To avoid copy paste of version ,what about using jakartaee bom for jakarta dependencies?
https://repo.maven.apache.org/maven2/jakarta/platform/jakarta.jakartaee-bom/10.0.0/
Thanks. I just wanted to make sure I had the correct picture. |
Consuming that in |
Context
Part of the following series of PRs:
Description
Upgrade Stapler from EE 9 to EE 10 by bumping the version numbers of the relevant libraries to match those used by Jetty 12 (EE 10) and updating the compatibility layer to match. The compatibility layer changes were implemented by throwing an exception whenever trying to invoke EE 8 functionality that is no longer supported by EE 10. In addition to being blocked on jenkinsci/jelly#140, this PR is ready for review and ready for merge from a Jenkins perspective, but it is not yet ready for merge from a CloudBees CI perspective (hence the "on hold" label).
Testing done
See jenkinsci/jenkins#10461.