Skip to content

JENKINS-56989 Default pty to false for sshCommand #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nrayapati merged 1 commit into from
Apr 16, 2019
Merged

JENKINS-56989 Default pty to false for sshCommand #19

nrayapati merged 1 commit into from
Apr 16, 2019

Conversation

@nrayapati
Copy link
Member

@nrayapati nrayapati commented Apr 14, 2019 •
edited
Loading

Description

See JENKINS-56989.

  • Default pty to false for sshCommand
  • This setting should be default to false by default not sure why I had it true during the initial phase.
  • Tested this locally and is working for the nodes (LINUX) that we are running on.
  • And this PTY is also applicable for other steps, so instead it is good to have control at the remote level.

@nrayapati nrayapati requested a review from ghenkes April 14, 2019 20:46
@nrayapati nrayapati self-assigned this Apr 14, 2019
@nrayapati nrayapati mentioned this pull request Apr 14, 2019
Closed
@nrayapati nrayapati requested a review from wwftw April 14, 2019 20:53
@nrayapati nrayapati merged commit fea9186 into master Apr 16, 2019
@nrayapati nrayapati deleted the JENKINS-56989 branch April 16, 2019 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ghenkes ghenkes ghenkes approved these changes

@wwftw wwftw wwftw approved these changes

Assignees

@nrayapati nrayapati

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nrayapati @ghenkes @wwftw