Persist timeZone as ZoneId directly #435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids that the timezone needs to be parsed frequently. This change is compatible from api and persistence perspective so no extra conversion is required. A change in core should be opened to allow the 2 classes generally that are now added explicitly.
mawinter69
commented
Sep 13, 2025
| @@ -0,0 +1,2 @@ | |||
| java.time.ZoneRegion | |||
There was a problem hiding this comment.
Both classes are needed. The first during saving and the second when loading
14 tasks
|
Prefer something like #425. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids that the timezone needs to be parsed frequently. This change is compatible from api and persistence perspective so no extra conversion is required.
A change in core should be opened to allow the 2 classes generally that are now added explicitly.
Alternative to #425
Testing done
Before this change configured the timezone to
Etc/GMT-9, then started with this change and timezone is properly set toEtc/GMT-9in the UI and when scheduling a build. Also tested with other timezones in a similar way.Submitter checklist