Skip to content

[SECURITY-2307] do not validate file path to avoid path transversal #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2022
Merged

[SECURITY-2307] do not validate file path to avoid path transversal #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/main/java/jenkins/plugins/publish_over_ssh/descriptor/BapSshCredentialsDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,7 @@ public FormValidation doCheckKeyPath(@QueryParameter final String value) {
if (!subject.hasPermission(Item.CONFIGURE)&&subject.hasPermission(Item.EXTENDED_READ)) {
return FormValidation.ok();
}
try {
return Jenkins.getInstance().getRootPath().validateRelativePath(value, true, true);
} catch (final IOException ioe) {
return FormValidation.error(ioe, "");
} catch (final NullPointerException npe) {
return FormValidation.error(npe, "");
}
return FormValidation.ok();
}

public FormValidation doTestConnection(@QueryParameter final String configName, @QueryParameter final String username,
Expand Down