Pass argLine to Maven Surefire Plugin so that agents can be connected to the tests run
#138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to the tests run
timja
approved these changes
Oct 9, 2020
|
@oleg-nenashev I think this is incompatible. @jeffret-b noticed this in jenkinsci/remoting#407 and I saw a similar error elsewhere recently, cannot recall where offhand. You need to define a default value, even if empty, like https://github.com/jenkinsci/plugin-pom/blob/61e2a27d70a9f4e24d32f2acf670de675f9960dc/pom.xml#L51 |
|
Yes, the change needs to occur here, with a defined default value. I had to do this in another project years ago so that things would work reliably. |
|
Unless someone is already working on it, I'll prepare a PR for here with an empty argLine. |
|
Thanks @jeffret-b ! It would be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on adding code coverage reporting to https://github.com/jenkinsci/jenkinsfile-runner/ . Unfortunately JaCoCo profile cannot run with the default configuration of the Maven Sure Fire plugin. JaCoCo plugin installs the Java agent and passes configuration through
argLine. This argline gets suppressed by the historical SUREFIRE-1588 patch.This patch fixes the behavior