Remove unnecessary workarounds #836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running BOM's
sample-plugintests against this PR, I found no Enforcer errors spanning recent weeklies all the way back to 2.361.x. Seems time to retire most of these workarounds. Sadly I had to keep the FindBugs workaround since otherwise I started getting annoyances like this inbuild-monitor-plugin:I still see automated upper bounds workarounds in PCT logs for
org.ow2.asm:asm,org.kohsuke:access-modifier-annotation, andjavax.servlet:javax.servlet-apias well, but only for plugins with very old plugin parent POMs that won't be affected by this change anyway. When they upgrade, they'll get both this change and the fixes required by this change.Testing done
See above.