use valid password for test code #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amends jenkinsci#723 that was working as the KeyStore was not validated. However jenkinsci/credentials-plugin#543 now validates the keystore and hence this test started failing as the password did not match
jtnord
commented
Jul 8, 2024
|
|
||
| File crt = new File(CredentialWrapperStepTest.class.getResource("dummy.p12").toURI()); | ||
| CertificateCredentialsImpl certCred = new CertificateCredentialsImpl(CredentialsScope.GLOBAL, "certCred1", "sample", "test", | ||
| CertificateCredentialsImpl certCred = new CertificateCredentialsImpl(CredentialsScope.GLOBAL, "certCred1", "sample", "password", |
Member
Author
There was a problem hiding this comment.
double checked this was the correct password with openssl pkcs12 -legacy -info -in ./src/test/resources/org/jenkinsci/plugins/pipeline/modeldefinition/steps/dummy.p12
fcojfernandez
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amends #723 that was working as the KeyStore was not validated.
However jenkinsci/credentials-plugin#543 now validates the keystore and hence this test started failing as the password did not match