Skip to content

Conversation

bncbhm
Copy link
Contributor

@bncbhm bncbhm commented Oct 26, 2021

A first test for AddedVersusDeletedLinesForensicsSeriesBuilder that uses Mockito

@bncbhm bncbhm changed the title Added versus deleted lines forensics series builder test A first test for AddedVersusDeletedLinesForensicsSeriesBuilder Oct 26, 2021
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change required.

// Given
AddedVersusDeletedLinesForensicsSeriesBuilder builder = new AddedVersusDeletedLinesForensicsSeriesBuilder();
ForensicsBuildAction actionStub = mock(ForensicsBuildAction.class);
when(actionStub.getCommitStatistics()).thenReturn(createCommitStatistics(0, 0));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use different values so we see that the key mapping is correct.


}

private CommitStatistics createCommitStatistics(final int added, final int delted) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private CommitStatistics createCommitStatistics(final int added, final int delted) {
private CommitStatistics createCommitStatistics(final int added, final int deleted) {

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #350 (33df498) into master (237fba3) will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #350      +/-   ##
============================================
+ Coverage     50.04%   50.59%   +0.54%     
- Complexity      253      256       +3     
============================================
  Files            42       42              
  Lines          1093     1093              
  Branches         92       92              
============================================
+ Hits            547      553       +6     
+ Misses          510      504       -6     
  Partials         36       36              
Impacted Files Coverage Δ
.../jenkins/plugins/forensics/miner/SizePieChart.java 0.00% <0.00%> (ø)
...AddedVersusDeletedLinesForensicsSeriesBuilder.java 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237fba3...33df498. Read the comment docs.

@bncbhm bncbhm requested a review from uhafner October 27, 2021 16:57
@uhafner uhafner merged commit dcf3912 into jenkinsci:master Nov 2, 2021
@uhafner uhafner changed the title A first test for AddedVersusDeletedLinesForensicsSeriesBuilder Add a unit test for AddedVersusDeletedLinesForensicsSeriesBuilder Nov 2, 2021
@uhafner uhafner added the tests Enhancement of tests label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Enhancement of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants