Skip to content

Conversation

Tjuri
Copy link
Contributor

@Tjuri Tjuri commented Oct 21, 2021

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Tjuri Tjuri changed the title Test/added versus deleted lines commit statistics series builder Test/AddedVersusDeletedLinesCommitStatisticsSeriesBuilder Oct 21, 2021
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that Jenkins does not mark the build as failed.

.containsEntry(DELETED, 20);
}

private CommitStatisticsBuildAction createCommitStatisticsBuildActionStub(int addedLines, int deletedLines) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uhafner uhafner mentioned this pull request Oct 26, 2021
6 tasks
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #346 (7806e09) into master (237fba3) will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #346      +/-   ##
============================================
+ Coverage     50.04%   50.59%   +0.54%     
- Complexity      253      256       +3     
============================================
  Files            42       42              
  Lines          1093     1093              
  Branches         92       92              
============================================
+ Hits            547      553       +6     
+ Misses          510      504       -6     
  Partials         36       36              
Impacted Files Coverage Δ
.../jenkins/plugins/forensics/miner/SizePieChart.java 0.00% <0.00%> (ø)
...AddedVersusDeletedLinesForensicsSeriesBuilder.java 66.66% <0.00%> (+66.66%) ⬆️
...rsusDeletedLinesCommitStatisticsSeriesBuilder.java 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237fba3...7806e09. Read the comment docs.

@Tjuri Tjuri requested a review from uhafner October 28, 2021 11:10
@uhafner uhafner merged commit 3b9dc34 into jenkinsci:master Nov 2, 2021
@uhafner uhafner changed the title Test/AddedVersusDeletedLinesCommitStatisticsSeriesBuilder Add a unit test for AddedVersusDeletedLinesCommitStatisticsSeriesBuilder Nov 2, 2021
@uhafner uhafner added the tests Enhancement of tests label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Enhancement of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants