Skip to content

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Oct 20, 2021

This PR replaces the png icons with vectorized icons looking less sharp/blurry on different scales.
https://issues.jenkins.io/browse/JENKINS-66946

Before After
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@uhafner
Copy link
Member

uhafner commented Oct 20, 2021

Since which Jenkins LTS release are SVG icons allowed in those elements? Maybe we need to bump the minimum Jenkins version.

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #342 (cba89bd) into master (e22348b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #342   +/-   ##
=========================================
  Coverage     50.04%   50.04%           
  Complexity      253      253           
=========================================
  Files            42       42           
  Lines          1093     1093           
  Branches         92       92           
=========================================
  Hits            547      547           
  Misses          510      510           
  Partials         36       36           
Impacted Files Coverage Δ
...ns/plugins/forensics/miner/ForensicsJobAction.java 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22348b...cba89bd. Read the comment docs.

@NotMyFault
Copy link
Member Author

NotMyFault commented Oct 20, 2021

2.289.1 contains the PR that adds the most sprites to core, but I'm not sure if was impossible to use svgs over pngs/gifs before.
To note, that is also the version the git plugin is using, which uses svg sprites in the build overview as well.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Oct 21, 2021
@uhafner uhafner merged commit 87191d3 into jenkinsci:master Oct 21, 2021
@NotMyFault NotMyFault deleted the style/master/use-vectorized-icons branch October 21, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants