A first test for ForensicsTableModel
#341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
============================================
+ Coverage 50.04% 52.88% +2.83%
- Complexity 253 257 +4
============================================
Files 42 42
Lines 1093 1093
Branches 92 92
============================================
+ Hits 547 578 +31
+ Misses 510 479 -31
Partials 36 36
Continue to review full report at Codecov.
|
uhafner
requested changes
Oct 26, 2021
| private static final int ONE_DAY = 60 * 60 * 24; | ||
|
|
||
| @Test | ||
| void shouldCreateForensicsTableModel(){ |
There was a problem hiding this comment.
You should install the CheckStyle plugin, then those warnings will be flagged in IntelliJ.
Comment on lines
21
to
37
| @Test | ||
| void shouldCreateForensicsTableModel(){ | ||
| RepositoryStatistics statistics = new RepositoryStatistics(); | ||
| ForensicsTableModel tableModel = new ForensicsTableModel(statistics); | ||
| assertThat(tableModel).isNotNull(); | ||
| } | ||
|
|
||
|
|
||
| @Test | ||
| void getId() { | ||
| RepositoryStatistics statistics = new RepositoryStatistics(); | ||
| ForensicsTableModel tableModel = new ForensicsTableModel(statistics); | ||
| assertThat(tableModel.getId()).isEqualTo(ForensicsJobAction.FORENSICS_ID); | ||
| } | ||
|
|
||
| @Test | ||
| void getColumns() { |
There was a problem hiding this comment.
I think it has no extra value if you separate this test in 3 methods: combine them in a single one.
| void getId() { | ||
| RepositoryStatistics statistics = new RepositoryStatistics(); | ||
| ForensicsTableModel tableModel = new ForensicsTableModel(statistics); | ||
| assertThat(tableModel.getId()).isEqualTo(ForensicsJobAction.FORENSICS_ID); |
There was a problem hiding this comment.
Use the generated assertions:
Suggested change
| assertThat(tableModel.getId()).isEqualTo(ForensicsJobAction.FORENSICS_ID); | |
| assertThat(tableModel).hasId(ForensicsJobAction.FORENSICS_ID); |
Comment on lines
41
to
48
| assertThat(tableModel.getColumns().size()).isEqualTo(7); | ||
| assertThat(tableModel.getColumns().get(0).getHeaderLabel()).isEqualTo(Messages.Table_Column_File()); | ||
| assertThat(tableModel.getColumns().get(1).getHeaderLabel()).isEqualTo(Messages.Table_Column_AuthorsSize()); | ||
| assertThat(tableModel.getColumns().get(2).getHeaderLabel()).isEqualTo(Messages.Table_Column_CommitsSize()); | ||
| assertThat(tableModel.getColumns().get(3).getHeaderLabel()).isEqualTo(Messages.Table_Column_LastCommit()); | ||
| assertThat(tableModel.getColumns().get(4).getHeaderLabel()).isEqualTo(Messages.Table_Column_AddedAt()); | ||
| assertThat(tableModel.getColumns().get(5).getHeaderLabel()).isEqualTo(Messages.Table_Column_LOC()); | ||
| assertThat(tableModel.getColumns().get(6).getHeaderLabel()).isEqualTo(Messages.Table_Column_Churn()); |
There was a problem hiding this comment.
This would be much simpler without duplications:
assertThat(tableModel.getColumns())
.hasSize(7)
.extracting(TableColumn::getHeaderLabel)
.containsExactly(
Messages.Table_Column_File(), ... );
| ForensicsTableModel tableModel = new ForensicsTableModel(statistics); | ||
| tableModel.getRows(); | ||
| assertThat(tableModel.getRows().size()).isEqualTo(1); | ||
| } |
uhafner
approved these changes
Oct 27, 2021
Comment on lines
+44
to
+45
| assertThat(actual).isInstanceOf(ForensicsRow.class); | ||
| assertThat((ForensicsRow) actual).hasAuthorsSize(0); |
There was a problem hiding this comment.
A simpler way to avoid the cast is:
assertThat(actual).isInstanceOfSatisfying(ForensicsRow.class,
row -> assertThat(row).hasAuthorsSize(0));
|
|
||
| assertThat(forensicsRow) | ||
| .hasFileName( | ||
| "<a href=\"fileName.-734768633\" data-bs-toggle=\"tooltip\" data-bs-placement=\"left\" title=\"filename\">filename</a>") |
There was a problem hiding this comment.
This might be too fragile but is ok for now. (It might break just because the UI changes.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first test for
ForensicsTableModel, which uses the constructor to create an instance and check getId(), getColumns() and getRows().