Skip to content

Add Support for Agent Roles #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 25, 2019
Merged

Add Support for Agent Roles #11

merged 8 commits into from
Jul 25, 2019

Conversation

AbhyudayaSharma
Copy link
Member

@AbhyudayaSharma AbhyudayaSharma commented Jul 17, 2019 •
edited
Loading

This pull request is a draft because it depends on #3 and is a work-in-progress.

@AbhyudayaSharma AbhyudayaSharma added enhancement New feature or request work-in-progress This Pull Request is not ready to be merged labels Jul 17, 2019
@AbhyudayaSharma AbhyudayaSharma requested a review from a team July 17, 2019 11:26
@AbhyudayaSharma AbhyudayaSharma self-assigned this Jul 17, 2019
@AbhyudayaSharma
Copy link
Member Author

I think that this PR is ready now. Just waiting for a conclusion on #3

@AbhyudayaSharma AbhyudayaSharma removed the work-in-progress This Pull Request is not ready to be merged label Jul 18, 2019
@AbhyudayaSharma
Copy link
Member Author

CI not triggering a build

oleg-nenashev
oleg-nenashev approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is going with CI here. If reopens do not help, just push a commit with some change.
The code looks good to me so IMHO we can merge it into the master branch for alpha/beta

src/main/java/io/jenkins/plugins/folderauth/FolderBasedAuthorizationStrategy.java
*
* @param role the role to be updated
*/
private void updateAclForAgentRole(@Nonnull AgentRole role) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not important: could look better with "ACL"

@AbhyudayaSharma AbhyudayaSharma mentioned this pull request Jul 23, 2019
Merged
@AbhyudayaSharma
Merge branch 'master' of https://github.com/jenkinsci/folder-auth-plugin
a60242e 
 into agent-roles

# Conflicts:
#	src/main/java/io/jenkins/plugins/folderauth/FolderAuthorizationStrategyManagementLink.java
#	src/main/resources/io/jenkins/plugins/folderauth/FolderAuthorizationStrategyManagementLink/index.jelly
#	src/main/resources/io/jenkins/plugins/folderauth/FolderAuthorizationStrategyManagementLink/index.properties
@AbhyudayaSharma AbhyudayaSharma marked this pull request as ready for review July 24, 2019 09:39
@AbhyudayaSharma
Copy link
Member Author

I am merging it now. After that, I will update #3 with the changes for agent roles.

@AbhyudayaSharma AbhyudayaSharma merged commit add17e5 into jenkinsci:master Jul 25, 2019
@AbhyudayaSharma AbhyudayaSharma deleted the agent-roles branch July 25, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees

@AbhyudayaSharma AbhyudayaSharma

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhyudayaSharma @oleg-nenashev