Skip to content

Conversation

AbhinavJha1023
Copy link

Replaced loops with Streams: Improved readability and performance.
Used collect(Collectors.toSet()): Eliminates duplicates.
Optimized removeTrailingEquals: Uses charAt check instead of multiple conditions.
Encapsulation: Marked helper methods as private for better structure.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Replaced loops with Streams: Improved readability and performance.
Used collect(Collectors.toSet()): Eliminates duplicates.
Optimized removeTrailingEquals: Uses charAt check instead of multiple conditions.
Encapsulation: Marked helper methods as private for better structure.
@AbhinavJha1023 AbhinavJha1023 requested a review from a team as a code owner March 18, 2025 14:31
@jtnord jtnord marked this pull request as draft March 18, 2025 14:34
@jtnord
Copy link
Member

jtnord commented Mar 18, 2025

the code does not compile.

@AbhinavJha1023
Copy link
Author

the code does not compile.

Let me check this once again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants