Skip to content

jep-227 downstream usage #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2023
Merged

jep-227 downstream usage #280

merged 2 commits into from
Nov 1, 2023

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Oct 26, 2023 •
edited by jglick
Loading

Testing done

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe Vlatombe mentioned this pull request Oct 26, 2023
Merged
@Vlatombe Vlatombe changed the title Downstream usage of new jep-227 APIs jep-227 downstream usage Oct 26, 2023
jglick
jglick approved these changes Oct 27, 2023
View reviewed changes
src/main/java/org/jenkinsci/plugins/credentialsbinding/BindingDescriptor.java
// as we cannot select from a user's credentials unless they are the only user submitting the build
// (which we cannot assume) thus ACL.SYSTEM is correct here.
return new Model().withAll(CredentialsProvider.lookupCredentials(type(), owner, ACL.SYSTEM, Collections.emptyList()));
return new Model().withAll(CredentialsProvider.lookupCredentialsInItem(type(), owner, ACL.SYSTEM2, Collections.emptyList()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or we can use List.of()

jglick
jglick reviewed Nov 1, 2023
View reviewed changes
@jglick jglick marked this pull request as ready for review November 1, 2023 21:19
@jglick jglick requested a review from a team as a code owner November 1, 2023 21:19
@jglick jglick enabled auto-merge November 1, 2023 21:19
@jglick jglick merged commit f929416 into jenkinsci:master Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlatombe @jglick