Skip to content

Conversation

jeffret-b
Copy link
Contributor

Increase the documented visibility of the recommendation to use single quotes whenever possible.

Increaed the documented visibility of the recommendation to use single quotes whenever possible.
@jeffret-b
Copy link
Contributor Author

@Wadeck, does this look like what you want?

Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have agreed to add a link to an article with details about password masking that could be broken depending on the content of the variables due to double quotes. This article is not yet written / up-to-date.

So this PR without the expected links (in both readme and help) has low value as there is no explanation about why ("complications" is not enough in this particularly difficult topic).

Do you expect the article to be a new one or a rewamp of an existing one?

@jeffret-b
Copy link
Contributor Author

Do you expect the article to be a new one or a revamp of an existing one?

I expect it to be a new one. There really isn't an existing one that it makes sense to revamp.

We could make that new document a blog post -- that format would make it easier to get something out more quickly, even if it's later followed up by more polished documentation.

Co-authored-by: Wadeck Follonier <[email protected]>
@jeffret-b jeffret-b requested a review from Wadeck October 5, 2020 20:10
@Wadeck
Copy link
Contributor

Wadeck commented Oct 14, 2020

Feedback provided in https://cloudbees.atlassian.net/browse/JENSEC-1069 (CloudBees internal ticket)

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkinsci/workflow-cps-plugin#370 by @car-roll will probably help more.

@jeffret-b
Copy link
Contributor Author

jenkinsci/workflow-cps-plugin#370 by @car-roll will probably help more.

Yes, I agree with that.

jeffret-b and others added 2 commits October 14, 2020 13:27
As it is already covered, as mentioned in Jesse's comment.
@jeffret-b
Copy link
Contributor Author

I updated this per Jesse's review comments, but it still needs coordination with other changes. It should be considered on hold for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants