Add a "Give Feedback" option in Help menu #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jendrikseipp
requested changes
Jan 10, 2021
|
I think the URL in the R is fine. It's good to show existing discussions before starting a new one. |
|
Thanks for the quick review! Added the changelog entry, and changed the sentence. |
|
Thanks, Rahul! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes in this pull request:
As mentioned in TODOs, I've added a "Give Feedback" option in Help menu.
(Copy of #550)
Copied suggestion:
I think that it would be better to redirect the user to
.../discussions/new/?category=ideas. @jendrikseipp what do you think?