Skip to content

Return primary response and request body fix #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Return primary response and request body fix #1197

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
278f43a
Return primary response and request body fix
nour-borgi Jun 27, 2023
2af9ffd
:Merge remote-tracking branch 'origin/master' into primary-res-req-bo…
rcrichton Sep 13, 2024
76892af
Fix implementation of kafka routing:
rcrichton Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/middleware/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ function setKoaResponse(ctx, response) {
}
}

// Save response body of the primary route
ctx.resBody = Buffer.isBuffer(response.body)
? response.body.toString()
: response.body

for (const key in response.headers) {
const value = response.headers[key]
switch (key.toLowerCase()) {
Expand Down Expand Up @@ -488,6 +493,11 @@ function sendRequest(ctx, route, options) {
}
}

if (route.primary) {
// Save request body of the primary route
ctx.reqBody = Buffer.isBuffer(ctx.body) ? ctx.body.toString() : ctx.body
}

if (response instanceof Error) {
orchestration.error = {
message: response.message,
Expand Down Expand Up @@ -657,7 +667,8 @@ function sendKafkaRequest(ctx, route) {
method: ctx.request.method,
path: ctx.request.url,
headers: ctx.request.headers,
body: ctx.body && ctx.body.toString()
requestBody: ctx.reqBody ?? '',
responseBody: ctx.resBody ?? ''
}

return producer
Expand Down