-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Use absolute_url filter for disqus #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wont |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it was using the full URL
instead of baseurl
so absolute_url
is correct.
@jekyllbot: merge +minor |
Thanks @DirtyF! |
How can I update my github-pages blog with this fix? rubygems.org has an old version, so I changed gem source to this repo in my Gemfile with:
I push it to github but disqus still does not work, and looking into source code I still get:
What am I doing wrong? |
@mdoliwa, it could be because Github Pages use a different version of Jekyll called |
Sorry to bring this issue up again, but the absolute URL still does not resolve for me. I'm seeing the same code generated as @mdoliwa using minima 2.1.0 at master@bcabdbd. |
@jenzz Make sure you have |
@mdoliwa Oops. I was indeed not setting the |
Fix #65
cc @jekyll/minima