Skip to content

Use absolute_url filter for disqus #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2016
Merged

Conversation

DirtyF
Copy link
Member

@DirtyF DirtyF commented Oct 22, 2016

Fix #65

cc @jekyll/minima

@ashmaroli
Copy link
Member

wont relative_url work in this context?

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was using the full URL instead of baseurl so absolute_url is correct.

@benbalter
Copy link
Contributor

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 48f836b into jekyll:master Oct 23, 2016
jekyllbot added a commit that referenced this pull request Oct 23, 2016
@benbalter
Copy link
Contributor

Thanks @DirtyF!

@DirtyF DirtyF deleted the fix-disqus-url branch October 23, 2016 18:08
@mdoliwa
Copy link

mdoliwa commented Nov 9, 2016

How can I update my github-pages blog with this fix?

rubygems.org has an old version, so I changed gem source to this repo in my Gemfile with:

gem 'minima', '~> 2.0', :git => 'https://github.com/jekyll/minima.git'

I push it to github but disqus still does not work, and looking into source code I still get:

    var disqus_config = function () {
      this.page.url = '/2016/11/09/hello-world.html';
      this.page.identifier = '/2016/11/09/hello-world.html';
    };

What am I doing wrong?

@ashmaroli
Copy link
Member

@mdoliwa, it could be because Github Pages use a different version of Jekyll called gem "github-pages" and that uses Rubygems version of Minima.. irrespective of what you specify in your Gemfile.

@jenzz
Copy link

jenzz commented Jan 18, 2017

Sorry to bring this issue up again, but the absolute URL still does not resolve for me.

I'm seeing the same code generated as @mdoliwa using minima 2.1.0 at master@bcabdbd.

@mdoliwa
Copy link

mdoliwa commented Jan 18, 2017

@jenzz Make sure you have url and baseurl fields setup correctly in your _config.yml

@jenzz
Copy link

jenzz commented Jan 18, 2017

@mdoliwa Oops. I was indeed not setting the url param correctly. It's working now. Thanks a lot!

@jekyll jekyll locked and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disqus url ignore baseurl
8 participants