Skip to content

Update description comment in _config #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2018
Merged

Update description comment in _config #203

merged 1 commit into from
Mar 9, 2018

Conversation

raoasifraza11
Copy link
Contributor

The baseurl: does't exists in the _config file.

pathawks
pathawks approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@pathawks pathawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🍻👍

@raoasifraza11
Copy link
Contributor Author

@pathawks you have approved these changes but still Review is required? 😕

@pathawks
Copy link
Member

pathawks commented Mar 9, 2018

I’m not a maintainer of Minima. Somebody else will need to merge this.

@DirtyF DirtyF merged commit 79441ea into jekyll:master Mar 9, 2018
@DirtyF
Copy link
Member

DirtyF commented Mar 9, 2018

Thanks @raoasifraza11

@jekyllbot jekyllbot mentioned this pull request Mar 10, 2018
Merged
@jekyll jekyll locked and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@pathawks pathawks pathawks approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raoasifraza11 @pathawks @DirtyF @jekyllbot