Skip to content

Formatted code #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2021
Merged

Formatted code #16

merged 3 commits into from
Dec 4, 2021

Conversation

OverloadedOrama
Copy link
Collaborator

@OverloadedOrama OverloadedOrama commented Nov 24, 2021

Run commands gdformat . and gdlint . from the godot-gdscript-toolkit to improve the code quality and ensure it follows GDScript's style guide and best practices. Functionality-wise, nothing should change. I'm working on doing the same to all of Pixelorama's codebase as well.

Note that gdlint still gives two Error: Max allowed line length (100) exceeded (max-line-length) error messages, but I'm not entirely sure what to do with these.
EDIT: Fixed in 13fd5cc

Also fixed issue with the main scene failing to load due to case-sensitivity.

Also fixed issue with the main scene not being loaded
@OverloadedOrama OverloadedOrama changed the title Formatted & linted code Formatted code Nov 24, 2021
@jegor377
Copy link
Owner

jegor377 commented Dec 3, 2021

Looks good to me, :) I will merge it but I don't know why files named "broken_1-8.png" are not in the PR if they are referenced in Main.gd. Could you add them or remove the reference? I don't know if it's intentional. :/

Przechwytywanie

@OverloadedOrama
Copy link
Collaborator Author

OverloadedOrama commented Dec 3, 2021

These existed before this PR, so I'm not sure why they are there either. This PR doesn't add any new lines to the code, it just reformatted already existing code. I went ahead and removed that code now though. :)

@jegor377
Copy link
Owner

jegor377 commented Dec 4, 2021

Thanks!

@jegor377 jegor377 merged commit 48c4d4c into jegor377:master Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants