#2409 の変更提案プルリクエスト #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Dec 29, 2024
| @@ -160,6 +160,7 @@ onMounted(async () => { | |||
| isAcceptTermsDialogOpen: | |||
| import.meta.env.MODE !== "development" && | |||
| store.state.acceptTerms !== "Accepted", | |||
| isInitialSettingsDialogOpen: store.state.openedEditor == undefined, | |||
There was a problem hiding this comment.
ここでopenedEditorが設定されているかどうかを見て、isInitialSettingsDialogOpenをtrueにしてます！
App.vueが表示されている直後のタイミングだと必ずstate.openedEditorはundefinedになってるので、エンジンが起動した後にダイアログを開くかどうかを判定してます。
利用規約ダイアログとかも開くかどうかここで判定しているので、同じ機構にしています。
（ちなみに、これは正直既存の実装がちょっと微妙なのですが、リファクタリングができていなくてそのままにって感じです。。。）
Comment on lines
+150
to
+154
| !store.state.isAcceptTermsDialogOpen && | ||
| !store.state.isCharacterOrderDialogOpen && | ||
| !store.state.isDefaultStyleSelectDialogOpen && | ||
| !store.state.isAcceptRetrieveTelemetryDialogOpen && | ||
| store.state.isInitialSettingsDialogOpen, |
There was a problem hiding this comment.
利用規約ダイアログ、キャラクター並び替えダイアログなどを設定し終わってからこのダイアログが開かれるようにしてます。
UX次第だけど、順番は変えてもいいかも。
| openedEditor: z.enum(["talk", "song"]).default("talk"), | ||
| openedEditor: z.enum(["talk", "song"]).optional(), |
There was a problem hiding this comment.
openedEditorはconfig.json設定においてデフォルトでtalkになるようになっていたのですが、デフォルトがundefinedになるようにしてます。
これで今まで開いたことがある人には「どっちにしますか？」ダイアログが開かれず、初めて起動した人はundefinedになってダイアログが開かれるはず！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
の変更提案プルリクです！
mergeしていただければ自動的に元のプルリクに反映されるはずです。
もちろんmergeせず自由に変更いただいても問題ないです！