menu-item is not a valid aria role #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @LucasPadovan, Thanks for the PR! Mind signing our Contributor License Agreement? When you've done so, go ahead and comment Yours truly, |
|
[clabot:check] |
|
CLA signature looks good 👍 |
|
Anyone around? |
|
So, nobody maintain this? |
|
@LucasPadovan Apologies for the delay. Thank you so much for contributing to this project. It is very much appreciated! |
|
👍 No problem! Thanks for approving this ^^ |
Skeletonxf
pushed a commit
to Skeletonxf/totally-automated-a11y-scanner
that referenced
this pull request
Mar 8, 2019
menu-item is not a valid aria role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Looking at the implementation of https://github.com/Khan/tota11y/blob/master/plugins/base.js#L80 I found that this may be breaking an accessibility rule related to aria roles after I ran an accessibility audit using Google Chrome:
According to w3.org
menu-itemis not correct and it should bemenuitem(without the dash) https://www.w3.org/TR/wai-aria/roles#roles_categorization.