Respects min argument for wait_random_exponential
#425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd
previously approved these changes
Dec 18, 2023
jd
previously approved these changes
Mar 2, 2024
|
Any update on merging this please? |
jd
previously approved these changes
Jul 26, 2024
jd
approved these changes
Jul 29, 2024
1 task
HuanzhiMao
added a commit
to ShishirPatil/gorilla
that referenced
this pull request
Jul 6, 2025
This PR updates the inference mechanism for Google Gemini models, replacing the use of Google Vertex AI with Google AI Studio. In addition, this PR downgrades `tenacity` from 9.0.0 → 8.5.0 because `google-genai` currently pins `tenacity<9.0`. ---- **Compatibility note on tenacity** Our code does exercise the retry path affected by [jd/tenacity #425](jd/tenacity#425), but the issue has no functional impact on our evaluation accuracy. Therefore, the temporary downgrade is considered safe. We will revert to tenacity ≥9.0 once python-genai removes the <9.0 pin (tracked in [googleapis/python-genai #1005](googleapis/python-genai#1005)).
incredibledevpy
added a commit
to incredibledevpy/gorilla-custom
that referenced
this pull request
Oct 28, 2025
This PR updates the inference mechanism for Google Gemini models, replacing the use of Google Vertex AI with Google AI Studio. In addition, this PR downgrades `tenacity` from 9.0.0 → 8.5.0 because `google-genai` currently pins `tenacity<9.0`. ---- **Compatibility note on tenacity** Our code does exercise the retry path affected by [jd/tenacity #425](jd/tenacity#425), but the issue has no functional impact on our evaluation accuracy. Therefore, the temporary downgrade is considered safe. We will revert to tenacity ≥9.0 once python-genai removes the <9.0 pin (tracked in [googleapis/python-genai #1005](googleapis/python-genai#1005)).
rairegalon
added a commit
to rairegalon/gorilla-custom
that referenced
this pull request
Oct 28, 2025
This PR updates the inference mechanism for Google Gemini models, replacing the use of Google Vertex AI with Google AI Studio. In addition, this PR downgrades `tenacity` from 9.0.0 → 8.5.0 because `google-genai` currently pins `tenacity<9.0`. ---- **Compatibility note on tenacity** Our code does exercise the retry path affected by [jd/tenacity #425](jd/tenacity#425), but the issue has no functional impact on our evaluation accuracy. Therefore, the temporary downgrade is considered safe. We will revert to tenacity ≥9.0 once python-genai removes the <9.0 pin (tracked in [googleapis/python-genai #1005](googleapis/python-genai#1005)).
johniebaptora
added a commit
to johniebaptora/gorilla-custom
that referenced
this pull request
Oct 29, 2025
This PR updates the inference mechanism for Google Gemini models, replacing the use of Google Vertex AI with Google AI Studio. In addition, this PR downgrades `tenacity` from 9.0.0 → 8.5.0 because `google-genai` currently pins `tenacity<9.0`. ---- **Compatibility note on tenacity** Our code does exercise the retry path affected by [jd/tenacity #425](jd/tenacity#425), but the issue has no functional impact on our evaluation accuracy. Therefore, the temporary downgrade is considered safe. We will revert to tenacity ≥9.0 once python-genai removes the <9.0 pin (tracked in [googleapis/python-genai #1005](googleapis/python-genai#1005)).
CodyOnGit
added a commit
to CodyOnGit/gorilla-custom
that referenced
this pull request
Oct 30, 2025
This PR updates the inference mechanism for Google Gemini models, replacing the use of Google Vertex AI with Google AI Studio. In addition, this PR downgrades `tenacity` from 9.0.0 → 8.5.0 because `google-genai` currently pins `tenacity<9.0`. ---- **Compatibility note on tenacity** Our code does exercise the retry path affected by [jd/tenacity #425](jd/tenacity#425), but the issue has no functional impact on our evaluation accuracy. Therefore, the temporary downgrade is considered safe. We will revert to tenacity ≥9.0 once python-genai removes the <9.0 pin (tracked in [googleapis/python-genai #1005](googleapis/python-genai#1005)).
CoinOfGreen
added a commit
to CoinOfGreen/gorilla-custom
that referenced
this pull request
Oct 30, 2025
This PR updates the inference mechanism for Google Gemini models, replacing the use of Google Vertex AI with Google AI Studio. In addition, this PR downgrades `tenacity` from 9.0.0 → 8.5.0 because `google-genai` currently pins `tenacity<9.0`. ---- **Compatibility note on tenacity** Our code does exercise the retry path affected by [jd/tenacity #425](jd/tenacity#425), but the issue has no functional impact on our evaluation accuracy. Therefore, the temporary downgrade is considered safe. We will revert to tenacity ≥9.0 once python-genai removes the <9.0 pin (tracked in [googleapis/python-genai #1005](googleapis/python-genai#1005)).
MagnusLabonne
added a commit
to MagnusLabonne/gorilla-custom
that referenced
this pull request
Nov 15, 2025
This PR updates the inference mechanism for Google Gemini models, replacing the use of Google Vertex AI with Google AI Studio. In addition, this PR downgrades `tenacity` from 9.0.0 → 8.5.0 because `google-genai` currently pins `tenacity<9.0`. ---- **Compatibility note on tenacity** Our code does exercise the retry path affected by [jd/tenacity #425](jd/tenacity#425), but the issue has no functional impact on our evaluation accuracy. Therefore, the temporary downgrade is considered safe. We will revert to tenacity ≥9.0 once python-genai removes the <9.0 pin (tracked in [googleapis/python-genai #1005](googleapis/python-genai#1005)).
BaddestNinja
added a commit
to BaddestNinja/gorilla-custom
that referenced
this pull request
Nov 19, 2025
This PR updates the inference mechanism for Google Gemini models, replacing the use of Google Vertex AI with Google AI Studio. In addition, this PR downgrades `tenacity` from 9.0.0 → 8.5.0 because `google-genai` currently pins `tenacity<9.0`. ---- **Compatibility note on tenacity** Our code does exercise the retry path affected by [jd/tenacity #425](jd/tenacity#425), but the issue has no functional impact on our evaluation accuracy. Therefore, the temporary downgrade is considered safe. We will revert to tenacity ≥9.0 once python-genai removes the <9.0 pin (tracked in [googleapis/python-genai #1005](googleapis/python-genai#1005)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Respects
minargument forwait_random_exponentialminargument only affects computing thehighrange of the uniform samplingmindoes not affect thelowrange of the uniform sampling, hence the sampled wait may be lower thanminspecifiedTests