Break saving output up into multiple functions and files #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbisits
added
Project 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug popped up that caused #158. See comments there for more information.
This PR breaks up the saving into multiple files (I wanted to do this anyway #157) and changes
η_spacetoϵ_maximum(aReductionusingmaximum!) because as far as I could tellη_spacewas causing the simulation to hang. I am not sure why but likely this solution is an improvement anyway. Functions inoutput_utils.jlhave been modified to deal with output being saved across multiple files.If possible it would be good to make it easy for another user to write their own
save_computed_output!function which could then be called inTLDNS_simulation_setup.Closes #157
Closes #158