Skip to content

Missing dep + add ! + use seawater_density #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbisits merged 3 commits into from
Oct 20, 2023
Merged

Missing dep + add ! + use seawater_density #142

jbisits merged 3 commits into from
Oct 20, 2023

Conversation

@jbisits
Copy link
Owner

@jbisits jbisits commented Oct 18, 2023 •
edited
Loading

Makie extension was missing NCDatatsets.jl
Closes #141
Closes #143

@jbisits jbisits changed the title Missing dep + add ! Missing dep + add ! + use seawater_density Oct 20, 2023
@jbisits
Copy link
Owner Author

jbisits commented Oct 20, 2023

Using seawater_density requires Oceananigans.jl v0.89.3 so the compat has been updated to 0.89 as no longer wokrs with older versions

@jbisits
Remove tests
20c0eba 
I added something similar to Oceananigans.jl for testing and am not using these anymore (in favour of `seawater_density` but I will not remove everything completely just yet..
@jbisits jbisits merged commit fd737de into main Oct 20, 2023
@jbisits jbisits deleted the minorfixes branch October 20, 2023 00:53
@jbisits jbisits added Project 2 Related to project two of my PhD Package dev Package development for TLDNS labels Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Package dev Package development for TLDNS Project 2 Related to project two of my PhD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move to using seawater_density from Oceananigans.jl Add ! to inferred_vertical_diffusivity as it modifies input

2 participants

@jbisits