Update watson.zsh-completion #379

snnwolf · 2020-06-07T05:32:48Z

fix: autocompletion won't work with zsh 5.8

jmaupetit · 2020-06-08T15:29:35Z

I'm using zsh 5.8 and it seems to work pretty well. Can you point me to the BC you are describing?

snnwolf · 2020-06-08T20:02:03Z

I'm working on Archlinux with installed packages.
_watson file without modify not loading

local/zsh 5.8-1
A very advanced and programmable command interpreter (shell) for UNIX
local/zsh-completions 0.32.0-1
Additional completion definitions for Zsh

jmaupetit · 2020-06-08T21:45:43Z

That's unfortunate. I need to test your changes locally but I've no idea of the impact of those.

snnwolf · 2020-06-09T04:48:37Z

Maybe archlinux in docker?

joelostblom · 2020-06-16T16:08:40Z

I noticed problems with completion too, but didn't have time to investigate so I just copied the autocompetion function and appended it to my .zshrc and this works as a temporary workaround.

sadid · 2020-10-23T01:10:43Z

I also couldn't make autocompletion work with zsh/Archlinux:

Watson, version 1.10.0
zsh 5.8-1 (x86_64-pc-linux-gnu)

I copied the provided watson.zsh-completion in watson root directory to /usr/share/zsh/site-functions/_watson. This is different than Document which might not work for arch linux. However, I tested /usr/local/share/zsh/site-functions/_watson as well by creating the zsh folder without success.

I also perform the compinit and load it beforehand.

However, using the changes mentioned here, I can verify it now can work with the updated version.

sadid

I have applied the changes on my archbox into /usr/share/zsh/site-functions/_watson and now zsh completion works.

jugendhacker · 2021-01-04T10:12:40Z

For me even with this PR applied zsh completion does not work...

jmaupetit · 2021-01-04T20:23:10Z

Works like a charm from here. Can you please fill the CHANGELOG and rebase your branch @snnwolf? I'll merge this.

jmaupetit · 2021-01-04T20:24:34Z

For me even with this PR applied zsh completion does not work...

@jugendhacker how did you integrate this completion file in your zsh configuration?

jugendhacker · 2021-01-04T21:46:46Z

For me even with this PR applied zsh completion does not work...

@jugendhacker how did you integrate this completion file in your zsh configuration?

I have a _watson file in /usr/share/zsh/site-functions containing the exact same content of this PR....

jmaupetit · 2021-01-04T22:45:08Z

Which zsh version are you running?

jugendhacker · 2021-01-05T08:10:00Z

It tells me zsh 5.8 (x86_64-pc-linux-gnu)

jmaupetit · 2021-01-05T09:00:07Z

Are you using oh-my-zsh?
Have you tried to reset the completion cache [1]?

[1] https://github.com/ohmyzsh/ohmyzsh/wiki/FAQ#how-do-i-reset-the-completion-cache

jugendhacker · 2021-01-05T11:24:09Z

1. Are you using oh-my-zsh?

2. Have you tried to reset the completion cache [1]?
[1] https://github.com/ohmyzsh/ohmyzsh/wiki/FAQ#how-do-i-reset-the-completion-cache

Yeah I use oh-my-zsh und yes I tried resetting the cache, but it did not help

jmaupetit · 2021-01-05T20:08:40Z

I also use OMZ 😉

To make it work I've:

copied this PR completion file in ~/.oh-my-zsh/custom/plugins/watson/_watson
added the watson plugin to my ~/.zshrc

plugins=(
  # [...]
  watson
)

reloaded my configuration: source ~/.zshrc

Please, tell me that it works on your machine ™️

jugendhacker · 2021-01-05T22:31:41Z

@jmaupetit okay so this did indeed work.... but it's not a very good solution because it's make it impossible for packagers to apply the completion with a package....

jmaupetit · 2021-01-06T09:05:44Z

@jmaupetit okay so this did indeed work.... but it's not a very good solution because it's make it impossible for packagers to apply the completion with a package....

True. Do you have time to investigate why we cannot use this completion file the vanilla-zsh way? I tried but did not succeed...

May this be related to OMZ?

snnwolf · 2021-01-06T11:02:14Z

Works like a charm from here. Can you please fill the CHANGELOG and rebase your branch @snnwolf? I'll merge this.

oohhh,,, :( could u help me? I don't working with rebase..
problem is: my first commit in jun 2020 and next commit with CHANGE.log in jan 2021, how to save other people's commits without hating?

ivan-volnov · 2021-02-08T10:09:33Z

This fix is working for me. Thanks.

zsh --version
zsh 5.8 (x86_64-apple-darwin20.0)

georgeto · 2021-03-02T11:41:09Z

This fix works for me too!

jmaupetit · 2021-03-02T16:17:09Z

Closed in favor of #409

Added: - The `log` command output can now be filtered to exclude projects and tags via `--ignore-project` and `--ignore-tag` (#395) - Python 3.8 support (#402) - Python 3.9 support (#402) - Support for the TZ environment variable to specify the local time zone (#391) Changed: - Upgrade to major arrow release 1.0.0 (#407) Fixed: - Zsh completion (#379) Removed: - Python 2.7 support (#305). - Python 3.5 support (#407).

Added: - The `log` command output can now be filtered to exclude projects and tags via `--ignore-project` and `--ignore-tag` (jazzband#395) - Python 3.8 support (jazzband#402) - Python 3.9 support (jazzband#402) - Support for the TZ environment variable to specify the local time zone (jazzband#391) Changed: - Upgrade to major arrow release 1.0.0 (jazzband#407) Fixed: - Zsh completion (jazzband#379) Removed: - Python 2.7 support (jazzband#305). - Python 3.5 support (jazzband#407).

* Resolve Issue jazzband#407: Migrate to arrow 1.0.0 - requirements.txt: specify arrow==1.00 - frames.py, fullmoon.py, watson.py: change "timestamp" to "int_timestamp" * Resolve Issue jazzband#407: Migrate to arrow 1.0.0 - cli.py: change "date.tzinfo = tz.tzlocal()" to "date.replace(tzinfo=tz.tzlocal())" * Update requirements.txt This makes sense, especially given that arrow is already up to 1.0.2 Co-authored-by: Julien Maupetit <[email protected]> * Resolve Issue jazzband#407: Migrate to arrow 1.0.0 - watson.cli.py: use date = date.replace(tzinfo=tz.tzlocal()) (date.replace does not modify the existing object) * Resolve Issue jazzband#407: Migrate to arrow 1.0.0 Update unit test cases: - tests/test_cli.py: replace arrow.arrow.datetime with arrow.arrow.dt_datetime - tests/test_watson.py: replace .timestamp with .int_timestamp * Resolve Issue jazzband#407: Migrate to arrow 1.0.0 - .travis.yml: remove python 3.5 - setup.py: require python >= 3.6 - CHANGELOG.md: mention arrow upgrade and drop of python 3.5 support * Update watson.zsh-completion fix: autocompletion won't work with zsh 5.8 * Use TZ environment variable to set the timezone (jazzband#411) Watson did not have a way to set the timezone, other than what the system used. In UNIX you can set the TZ variable to represent the timezone you want your programs to respect. * Bump release to 2.0.0 Added: - The `log` command output can now be filtered to exclude projects and tags via `--ignore-project` and `--ignore-tag` (jazzband#395) - Python 3.8 support (jazzband#402) - Python 3.9 support (jazzband#402) - Support for the TZ environment variable to specify the local time zone (jazzband#391) Changed: - Upgrade to major arrow release 1.0.0 (jazzband#407) Fixed: - Zsh completion (jazzband#379) Removed: - Python 2.7 support (jazzband#305). - Python 3.5 support (jazzband#407). * Fix year in 2.0.0 release Believe it or not its 2021! * Gracefully handle empty stop time (jazzband#418) Recent arrow library update broke the current frame edition. * Bump release to 2.0.1 Fixed: - Ability to `edit` the current frame (jazzband#418) * Add 'notes' field to frames. This is a large commit that adds the following: 1. Syntax: `watson stop --notes "some additional information"`. 2. Print only non-empty notes in log. 3. Always pass id to `new_frame` so that the length of array with/without notes doesn't cause ambiguity. 4. Print a warning message and the existing note if overwriting a note. 5. Print notes in report. Primary work here was done by the following people: Co-authored-by: Tristan Pratt <[email protected]> Co-authored-by: Joel Ostblom <[email protected]> * notes: Print notes in `watson log`. * notes: Fix tests. * Set requirements for click >= 8.0 and rename autocompletion parameter to shell_complete. Remove 'multiple' paramater on reporting option Co-authored-by: Jason Youzwak <[email protected]> Co-authored-by: veganjay <[email protected]> Co-authored-by: Julien Maupetit <[email protected]> Co-authored-by: Nikolay Shkrylev <[email protected]> Co-authored-by: Eddie Ash <[email protected]> Co-authored-by: Julien Maupetit <[email protected]> Co-authored-by: Matthew Barry <[email protected]> Co-authored-by: Rohitt Vashishtha <[email protected]> Co-authored-by: Tristan Pratt <[email protected]> Co-authored-by: Joel Ostblom <[email protected]>

Update watson.zsh-completion

2b6ebd4

fix: autocompletion won't work with zsh 5.8

jmaupetit added improvement needs help labels Jun 8, 2020

sadid approved these changes Oct 23, 2020

View reviewed changes

jmaupetit assigned snnwolf Jan 4, 2021

joclement mentioned this pull request Jan 12, 2021

Tab completion not working on Bash or Zsh #400

Closed

jonasatnewton mentioned this pull request Feb 20, 2021

zsh autocompletion doesn't work #406

Closed

georgeto mentioned this pull request Mar 2, 2021

Fix zsh completion #409

Merged

jmaupetit closed this Mar 2, 2021

jmaupetit mentioned this pull request Mar 19, 2021

Bump release to 2.0.0 #415

Merged

Uh oh!

Update watson.zsh-completion #379

Update watson.zsh-completion #379

Uh oh!

Conversation

snnwolf commented Jun 7, 2020

Uh oh!

jmaupetit commented Jun 8, 2020

Uh oh!

snnwolf commented Jun 8, 2020

Uh oh!

jmaupetit commented Jun 8, 2020

Uh oh!

snnwolf commented Jun 9, 2020

Uh oh!

joelostblom commented Jun 16, 2020

Uh oh!

sadid commented Oct 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sadid left a comment

Choose a reason for hiding this comment

Uh oh!

jugendhacker commented Jan 4, 2021

Uh oh!

jmaupetit commented Jan 4, 2021

Uh oh!

jmaupetit commented Jan 4, 2021

Uh oh!

jugendhacker commented Jan 4, 2021

Uh oh!

jmaupetit commented Jan 4, 2021

Uh oh!

jugendhacker commented Jan 5, 2021

Uh oh!

jmaupetit commented Jan 5, 2021

Uh oh!

jugendhacker commented Jan 5, 2021

Uh oh!

jmaupetit commented Jan 5, 2021

Uh oh!

jugendhacker commented Jan 5, 2021

Uh oh!

jmaupetit commented Jan 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snnwolf commented Jan 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivan-volnov commented Feb 8, 2021

Uh oh!

georgeto commented Mar 2, 2021

Uh oh!

jmaupetit commented Mar 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sadid commented Oct 23, 2020 •

edited

Loading

jmaupetit commented Jan 6, 2021 •

edited

Loading

snnwolf commented Jan 6, 2021 •

edited

Loading