Skip to content

In test with type CEST we have several tests in one file. If one test in a file fails, all test must fail. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akademic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

In test with type CEST we have several tests in one file. If one test in a file fails, all test must fail. #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions App/Lib/Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class Test
'PASSED', // Functional & Acceptance Test
'OK \(' // Unit Test
),
'failed' => 'FAILURES',
'failed' => 'FAIL',
);

/**
Expand Down Expand Up @@ -275,14 +275,25 @@ public function getState()
*/
public function setLog($lines = array())
{
$has_fail = false;
$has_pass = false;
foreach ($lines as $line) {

if ($this->checkLogForTestPass($line))
$this->setPassed();
if ($this->checkLogForTestPass($line)) {
$has_pass = true;
}

if($this->checkLogForTestFail($line)) {
$has_fail = true;
}

// Filter the line of any junk and add to the log.
$this->log[] = $this->filterLog($line);
}

if( $has_pass && !$has_fail ) {
$this->setPassed();
}
}

/**
Expand Down Expand Up @@ -317,6 +328,18 @@ public function checkLogForTestPass($line)
return count(preg_grep("/({$this->passed_regex})/", array($line))) > 0;
}

/**
* Check if it contains any text that indiciates that the test has failed.
*
* @param string $line
* @return boolean
*/
public function checkLogForTestFail($line)
{
if(preg_match('/'.$this->responses['failed'].'/', $line)) return true;
return false;
}

/**
* Reset a Test back to default.
*/
Expand Down