Skip to content

Solve crash when opening help for Classical Meta-Analysis #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
+9 −5
Merged

Solve crash when opening help for Classical Meta-Analysis #6007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions QMLComponents/controls/jasplistcontrol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ bool JASPListControl::containsInteractions() const

void JASPListControl::termsChangedHandler()
{
if (checkLevelsConstraints())
if (model() && checkLevelsConstraints())
{
setColumnsTypes(model()->getUsedTypes());
setColumnsNames(model()->terms().values());
Expand Down Expand Up @@ -245,7 +245,7 @@ JASPControl *JASPListControl::getRowControl(const QString &key, const QString &n

columnType JASPListControl::getVariableType(const QString &name)
{
return model()->getVariableType(name);
return model() ? model()->getVariableType(name) : columnType::unknown;
}

int JASPListControl::count()
Expand Down Expand Up @@ -273,7 +273,8 @@ std::vector<std::string> JASPListControl::usedVariables() const

JASPControls JASPListControl::getMDSubItems(const QQuickItem*) const
{
const Terms& terms = model()->terms();
if (!model())
return {};

// If row components are used, use only the items of the first row (if exists) to generate the help.
const ListModel::RowControlMap & map = model()->getAllRowControls();
Expand Down Expand Up @@ -329,7 +330,7 @@ bool JASPListControl::hasMandatoryType() const

bool JASPListControl::_checkLevelsConstraintsForVariable(const QString& variable)
{
if (variable.isEmpty())
if (variable.isEmpty() || !model())
return true;

columnType type = (columnType)model()->requestInfo(VariableInfo::VariableType, variable).toInt();
Expand Down Expand Up @@ -377,6 +378,9 @@ bool JASPListControl::_checkLevelsConstraints()
{
bool checked = true;

if (!model())
return checked;

for (const Term& term : model()->terms())
{
if (!_checkLevelsConstraintsForVariable(term.value()))
Expand Down Expand Up @@ -429,7 +433,7 @@ void JASPListControl::_setAllowedVariables()

emit allowedColumnsIconsChanged();

if (form() && form()->initialized())
if (model() && form() && form()->initialized())
// If the allowed columns have changed, then refresh the model so that columns that are not allowed anymore are removed.
model()->refresh();
}
Expand Down
Loading