Skip to content

Add GroupTitleSmall to Description #5881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

Add GroupTitleSmall to Description #5881

merged 2 commits into from
May 9, 2025

Conversation

JorisGoosen
Copy link
Contributor

@JorisGoosen JorisGoosen commented May 8, 2025 •
edited
Loading

@JorisGoosen JorisGoosen requested review from boutinb and koenderks May 8, 2025 15:24
shun2wang
shun2wang reviewed May 9, 2025
View reviewed changes
Copy link
Contributor

@shun2wang shun2wang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also make the highlight color rect right margin as same as it's left? OR not to set any margins on both sides also better.
also the Right-click menu in data editor.

@koenderks
Copy link
Contributor

It looks okay, but can you make it so that if no icon is specified it just shows the title without an icon?

image

@JorisGoosen
Copy link
Contributor Author

image image

As you can see the grouptitles are not aligned with the normal entries, with or without icon.
But I kind of like the clear indication of a break from just the outlining so I left it like this

koenderks
koenderks approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@koenderks koenderks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me! Maybe we could do with a little less space between the large header and the line below them, but that is preference.

image

@boutinb boutinb merged commit 345dda9 into jasp-stats:development May 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boutinb boutinb boutinb approved these changes

+2 more reviewers

@shun2wang shun2wang shun2wang left review comments

@koenderks koenderks koenderks approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JorisGoosen @koenderks @boutinb @shun2wang