Check levels of filtered variables dynamically

[boutinb]

The levels constraints in Variables Lists did not take the label filtering into account.
Also the levels constraints should be checked dynamically, that is each time the filtering is changed, or the constraints self changes.
Fixes jasp-stats/jasp-issues#2853
Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/2639
Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/2640
Fixes jasp-stats/jasp-issues#2853

[JorisGoosen]

@boutinb is this the pr that should go into the hotfix?
If so we should merge it to stable and not to development right?

[boutinb]

@boutinb is this the pr that should go into the hotfix? If so we should merge it to stable and not to development right?

Yep! I have rebased the branch

[JorisGoosen]

https://github.com/JorisGoosen/jasp-desktop/tree/checkForLevelsWithFilter

[JorisGoosen]

@boutinb you will let me know when this is ready for review again right?

[boutinb]

@boutinb you will let me know when this is ready for review again right?

This is now ready for review.
I have made an optimization for the counting of filtered levels: I tested it with 1M rows, adding several variables in a model is now significant quicker.

[JorisGoosen]

Very nice!

[Joao-O-Santos]

Thank you for fixing this labeling issue so quickly and for all the work you do!
Apologies if this is not the correct place to ask this question.

@JorisGoosen, would you happen to have a date for the release with this bugfix (I'm guessing version 0.19.1)?
I'm collaborating in a course that recently switched to JASP and we're getting everything ready for this new academic year.
We really like that version 0.19 adds the option to check the qqplot for the residuals in more models/tests.
In the last semester we sometimes had exercises that require students to apply filters.
I'm just trying to see if we'll have a new release before classes start or if we should remove the exercises with filters until then (no worries either way).

I guess the fix is already in the nightly builds, but I fear teaching students to install the nightly builds is more trouble than its worth (it will be better to remove the exercises with filters until the bugfix is released in the stable build).

[boutinb]

@Joao-O-Santos We will deliver a hotfix version (0.19.1) with this just this fix next week.

[Joao-O-Santos]

@Joao-O-Santos We will deliver a hotfix version (0.19.1) with this just this fix next week.

Thank you so much for the quick reply!
Amazing news!