Fix _removeModels regression #3803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jashkenas#3693. This leaves open the question of whether events triggered on the model during a ‘remove’ listener should also trigger on the model. Just something to revisit for V2. ```js col.on('other', (model) => { // Should this be triggered? }); col.on('remove', (model) => { // If the model is really "removed" (we can't `#get` it anymore) // by the time this listener is called, then I'd argue that this // shouldn't trigger the 'other' event on the collection... model.trigger('other'); }); ```
jashkenas
added a commit
that referenced
this pull request
Sep 25, 2015
Fix _removeModels regression
|
All events maybe not, but a |
|
I think this warrants a |
|
Want to add a test that |
|
It's in #3806, but I'm waiting till v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3693.
This leaves open the question of whether events triggered on the model
during a ‘remove’ listener should also trigger on the collection. Just
something to revisit for V2.