feat pygtfs/loader: if agency_id is not defined in routes.txt, it completes this value instead of leaving it as None #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pletes this value instead of leaving it as None agency_id on routes.txt is only required if multiple agencies are defined in agency.txt Instead of leaving agency_id as None on routes.txt, we set it to the first agency_id in case there is only one agency (univocal)
…ew feature of parent commit It loads a GTFS where agency_id is not defined on routest.txt, and check whether agency_id has been completed as expected
jarondl
reviewed
Jul 17, 2025
| # Empty row. | ||
| continue | ||
|
|
||
| if gtfs_class == Agency: |
There was a problem hiding this comment.
I wonder if this would be cleaner in a post-processing fix up. After reading all of the tables, you can check the number of agencies, and issue an update.
I haven't touched this code or sqlalchemy for a very long time, but it should be doable. Perhaps something like
# find if there is only one agency.. Based on:
select(Agency.agency_id).all()# update it if you need to
if len(agency_ids == 1):
session.update(Route)
.where(routes.c.agency_id.is_(None)
.values(agency_id=agency_id)What do you say? Does that make sense?
| continue | ||
|
|
||
| if gtfs_class == Agency: | ||
| # agency_id on routes.txt is only required if multiple agencies are defined in agency.txt |
There was a problem hiding this comment.
If we do follow this route, can you add to the comment that agencies are always processed before routes? (That's true, but a casual reader might miss this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
agency_id on routes.txt is only required if multiple agencies are defined in agency.txt
Instead of leaving agency_id as None on routes.txt, we set it to the first agency_id in case there is only one agency (univocal)
one specific test has been added in order to test this new feature