Skip to content

Conversation

@layananes
Copy link
Contributor

Improves accessibility by adding a title attribute to the GitHub button iframe.

Description

This adds a descriptive title attribute to the GitHub button iframe to improve accessibility.
Fixes issue #211

Related Issue

Fixes #211

Screenshots/Screencasts

Screenshot 2025-10-18 131616

Notes to Reviewer

Improves accessibility by adding a title attribute to the GitHub button iframe.
@vercel
Copy link

vercel bot commented Oct 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
jargons-dev Ready Ready Preview Comment Oct 18, 2025 10:26am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@babblebey babblebey changed the title Add descriptive title to GitHub button iframe fix(accessibility): Add descriptive title to GitHub button iframe Oct 18, 2025
Copy link
Member

@babblebey babblebey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @layananes

Thank you for making your first contribution to the project 🎊

Here a few things to note for your next one 😉

  • I modified the PR title by appending fix(accessibility): to it, this is to following the conventional commit standard for naming commits
  • Please ensure you've been assigned to an issue before starting to work on it, this is to avoid cases where multiple people work on thesame issue.

@babblebey babblebey added the hacktoberfest-accepted Contribution counted towards hacktoberfest label Oct 18, 2025
@babblebey
Copy link
Member

Hey @layananes

I'd like your feedback...

  • Did you run the project locally??
  • How was your experience following the docs as you did?
  • Is this your first ever contribution to Open source?

@babblebey babblebey merged commit edd06e7 into jargonsdev:main Oct 18, 2025
5 checks passed
@layananes
Copy link
Contributor Author

Good day!
I sadly did not run it locally, though it is indeed my first ever contribution😊
Following the docs was simple and clear and I did not face any issues!
Apologies for working on it right away too, as I am still familiarizing myself with GitHub and open source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Contribution counted towards hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility: Add missing descriptive title for GitHub button iframe

2 participants