Skip to content

Avoid data race when closing body #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
+10 −0
Merged

Avoid data race when closing body #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd06c69
fix: avoid data race when closing body
DavyJohnes Aug 18, 2025
1ab9927
fix: protect all body-related methods with mutext
DavyJohnes Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions response.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,7 @@ type lenReadSeeker interface {

type dummyReadCloser struct {
orig any // string or []byte
mu sync.Mutex // protects operations over body
body lenReadSeeker // instanciated on demand from orig
}

Expand All @@ -766,17 +767,26 @@ func (d *dummyReadCloser) setup() {
}

func (d *dummyReadCloser) Read(p []byte) (n int, err error) {
d.mu.Lock()
defer d.mu.Unlock()

d.setup()
return d.body.Read(p)
}

func (d *dummyReadCloser) Close() error {
d.mu.Lock()
defer d.mu.Unlock()

d.setup()
d.body.Seek(0, io.SeekEnd) //nolint: errcheck
return nil
}

func (d *dummyReadCloser) Len() int {
d.mu.Lock()
defer d.mu.Unlock()

d.setup()
return d.body.Len()
}