-
Notifications
You must be signed in to change notification settings - Fork 9
Documentation & dependency upgrades #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b823efb
to
43b4fdd
Compare
Tested rendering, nothing broke gif looks great, though it obviously looks robotic and unnatural My immediate reaction is that when the header Somehow typing the paragraph text is better, but are they even different speeds? If filesize is very important, it's fine by me, otherwise I might want to slow it just a little bit. |
Same speeds haha
The current one is 3.7MB at 15FPS with 30ms delay between keystrokes. With 40ms at 15FPS it's 3.9MB and looks like this: I think anything under 5MB is definitely acceptable. Do you prefer the 40ms? Or how much slower were you thinking? |
Yeah I would say I prefer the 40ms over the 30ms. Maybe we could go with this? |
Made the adjustments! Also removed the images from the repo, maybe you can adjust your AUR packages so they shallow-clone the repo, i.e. git clone --depth 1 --branch main https://github.com/jannis-baum/Vivify.git then there is a real benefit from it ^^ but low priority I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, just realized this needs an approval from me 😄 Gif looks great, I checked once again.
Said this elsewhere but for here as well: the AUR packages do the cloning implicitly (I haven't written a git clone
anywhere) plus the source probably isn't kept after building so I'll probably not do anything about that, but if it's ever relevant I'll keep that in mind.
ce99d2f
to
76d1641
Compare
76d1641
to
3ce5084
Compare
Close #226
I also upgrade dependencies in this PR because we had some security alerts again, this time as far as I can tell there was nothing that broke. Dependencies with breaking changes were:
To-dos