-
Notifications
You must be signed in to change notification settings - Fork 11
Closed as not planned
Labels
type:featureNew feature or requestNew feature or request
Description
Followup: #233
Related: #141 (comment)
About the icons, I would strongly prefer to avoid introducing a second source of icons. The Octicons probably have something suitable. If not, I'd rather switch to whatever new source for everything instead of having two.
Initial reasons I'm suggesting to switch to Lucide:
- in alerts customization, while octicons are perfect for GitHub's default alerts, they're disappointingly limited for anything a little more creative
- lucide on the other hand would be very nice for that, plus the focus on consistency would make this a nice "default namespace" for our icons
- in Obsidian style callouts #233 we allow providing the svgs outside of octicons, but usually they don't work just like that, because octicons are colored using
fill: <color>
, and e.g. lucide are colored usingstroke: <color>
. So if you'd want to supplement octicons with lucide, the icons are by default completely filled.
Replacements for all our current octicons with lucide:
octicon | lucide | |
---|---|---|
Back button | chevron-left | chevron-left |
Dir icon | file-directory-fill | folder (would be filled) |
File icon | file | file |
Copy button | copy | copy |
Copy check | check | check |
Copy error | x | x |
Alert: note | info | info |
Alert: tip | light-bulb | lightbulb |
Alert: important | report | message-square-warning |
Alert: warning | alert | alert |
Alert: caution | stop | octagon-alert |
What's important to me is that if replaced by these, the icons would look just as appropriate. I'll make some comparisons with screenshots later.
Metadata
Metadata
Assignees
Labels
type:featureNew feature or requestNew feature or request