Support injecting metadata as new field #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows services to add some data which can be correlated with a specific request without trying to match specific time/url/... by hand in the logs. Any string assigned to first `metadata` parameter will be copied verbatim to the logged `metadata` field.
Owner
|
This should be 👌. The only thing I want to be wary of here is that in the future, this project could cover Network Error Logging and more implementations of the Reporting API but I suspect they would be implemented on different paths, not query strings or anything that would interfere here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows services to add some data which can be correlated with a specific
request without trying to match specific time/url/... by hand in the logs.
Any string assigned to first
metadataparameter will be copied verbatim to thelogged
metadatafield.