fix: system language version

[lmmx]

Description

• Closes "Invalid language_version value: system" encountered with npm-based local hooks #698

Simple fix to the bug reported, does what pre-commit does now

I don't really get what "language_version: system" means but my impression is we are doing the same as pre-commit

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.02%. Comparing base (c8b69c6) to head (3687936).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #898   +/-   ##
=======================================
  Coverage   90.02%   90.02%           
=======================================
  Files          64       64           
  Lines       11999    11999           
=======================================
  Hits        10802    10802           
  Misses       1197     1197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[j178]

I think language_version: system has an implication that it should just use whatever toolchain is already installed on the system, without trying to download a new one. This PR makes system work the same as default, which does work, but we’re losing that “don’t install anything new” behavior that system was supposed to have.

[lmmx]

I think language_version: system has an implication that it should just use whatever toolchain is already installed on the system, without trying to download a new one. This PR makes system work the same as default, which does work, but we’re losing that “don’t install anything new” behavior that system was supposed to have.

I see what you mean, there is meant to be logic per-language like NodeRequest for language: node. We probably instead want to implement a LanguageRequest::System variant and subsequent per-language variants

• node: NodeRequest
• python: PythonRequest
• go: GoRequest

[j178]

Closing in favor of #949, thanks for your work!