Skip to content

chore!: change eth_price to native_price on Quote #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore!: change eth_price to native_price on Quote #1366

wants to merge 2 commits into from
+13 −13

Conversation

@Peponks9
Copy link

@Peponks9 Peponks9 commented Sep 9, 2025

Changes Made

  • Updated the Quote structure to use native_price instead of eth_price.

Testing

  • Verified that the documentation accurately reflects the current code implementation.
  • Ran `cargo test to ensure no regressions in the codebase.

Closes #1243
cc @joshieDo

@Peponks9 Peponks9 requested a review from joshieDo as a code owner September 9, 2025 23:50
klkvr
klkvr reviewed Sep 10, 2025
View reviewed changes
Peponks9
Peponks9 commented Sep 10, 2025
View reviewed changes
Copy link
Author

@Peponks9 Peponks9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @klkvr, porto-integration.md back to normal :)

klkvr
klkvr approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though this is breaking so I'd like to hold this off until v25

@klkvr klkvr added Breaking: SDK Breaks the SDK blocked labels Sep 11, 2025
@klkvr klkvr changed the title chore: change eth_price to native_price on Quote chore!: change eth_price to native_price on Quote Sep 11, 2025
mattsse
mattsse approved these changes Sep 13, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but marking as blocked

@joshieDo
Copy link
Contributor

my bad, forgot about this one for v26. will be sure to include it in v27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes

@klkvr klkvr klkvr approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees

No one assigned

Labels

blocked Breaking: SDK Breaks the SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change eth_price to native_price on Quote

4 participants

@Peponks9 @joshieDo @mattsse @klkvr