-
-
Notifications
You must be signed in to change notification settings - Fork 316
Description
Describe the bug
The "Open URL" and "Copy Url" functionality hangs and/or crashes the application when too many files are selected prior to simply hovering over the option. I have accidently crashed the application over 3 times now just trying to bulk delete files just because I moved my mouse over the option while going down to the delete option in the right-click context menu. Even hovering over "Open Url" in the File menu bar item causes the same effect.
To Reproduce
Steps to reproduce the behavior:
- Connect to AWS S3 or Rackspace Cloud Files.
- Select many files, like 30+ or 100+, by either clicking one, holding shift, and clicking another so it selects everything in between, or pressing Ctrl + A, or however you'd like to do it.
- Open the context menu by right clicking any of the files while they are all selected (alternatively, the File menu bar item). Move your mouse over "Copy URL" or Open URL".
- At this point the application will either hang or crash.
Expected behavior
I would hope that the application wouldn't crash, or at least just know its limit and not try to do such an expensive process without explicit direction from the user. Suggestions:
- Only have it get the URLs of the first few selected items.
- Asynchronously fetch each URL individually as the context item remains hovered over, updating the context window with more information as it comes. Ensure the operation doesn't block the drawing to the window, or at least provides some breathing room to the draw operation so it doesn't become unresponsive. Cancel all the asynchronous operations when mouse exists the context item to prevent furthering hanging/operations.
- Don't have this operation run within the context menu automatically on mouse hover. Move the operation to a modal window when you click "Copy URL" and have the operations run within that window. This way, the operation is a deliberate action the user wants to go through, rather than an accidental action.
Screenshots
An example of me selecting 100+ files, right clicking and moving my mouse past "Copy URL". It hangs here for several seconds before becoming responsive again.
Here is another example, this time with 500+ selected files and it becoming unresponsive, eventually regaining control after a minute or so. The big black rectangle is a visual glitch that happens as a result of it becoming unresponsive and me clicking it a few times:
Desktop:
- OS: Windows 10 Pro x64
- Version: 8.7.1 (40770)
- RAM: 32 GB
- Processor: Intel i7-12700K 3.60 Ghz
Log Files
cyberduck.log