fix(ZMSKVR-615): notification of session timeout #1372
Conversation
|
Warning Rate limit exceeded@matthilo96 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 49 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughAdds an optional integer reservationDuration to ThinnedScope, propagates it through mappers and the API facade, updates schema and many tests, and implements a frontend reservation timer (provide/inject + useReservationTimer) that gates CustomerInfo and AppointmentSummary with session-timeout translations and an error state. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant View as AppointmentView.vue
participant Hook as useReservationTimer
participant Cust as CustomerInfo.vue
participant Sum as AppointmentSummary.vue
User->>View: Reserve appointment
View->>View: reservationStartMs = Date.now()
View->>Cust: provide appointment, reservationStartMs
View->>Sum: provide appointment, reservationStartMs
rect rgba(200,220,255,0.12)
note over Hook: compute deadline = reservationStartMs + reservationDuration (minutes)
Cust->>Hook: useReservationTimer()
Sum->>Hook: useReservationTimer()
Hook-->>Cust: isExpired, remainingMs, timeLeftString
Hook-->>Sum: isExpired, remainingMs, timeLeftString
end
alt isExpired == true
Cust-->>User: show session expired callout (only back)
Sum-->>User: show session expired callout (actions hidden)
else
Cust-->>User: show form and Next button
Sum-->>User: show summary and action buttons
end
sequenceDiagram
autonumber
participant Src as Source Scope
participant Map as MapperService
participant Facade as ZmsApiFacadeService
participant Thin as ThinnedScope
participant Office as Office
Src-->>Map: input Scope or ThinnedScope
Map->>Map: extractReservationDuration(scope)
Map-->>Facade: reservationDuration value
Facade->>Thin: construct(..., reservationDuration)
Facade->>Office: construct(..., reservationDuration)
Thin-->>Facade: toArray() includes reservationDuration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentUpdateControllerTest.php (1)
81-89: Fix typo in provider payload key in AppointmentUpdateControllerTestOur search shows the only occurrence of the misspelled key is in the test itself, and no mappings in the controller emit “displayame”. All other controller tests use the correct “displayName”. Please update the stub in zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentUpdateControllerTest.php to match the rest of the suite:
• File: zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentUpdateControllerTest.php
Lines: 85–89- 'displayame'=> '', + 'displayName'=> '',This will align the test with the actual API contract and ensure it fails if the implementation ever regresses.
zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentByIdControllerTest.php (1)
53-57: Guard against undefined index for captchaTokenAccessing $responseBody['captchaToken'] before checking it exists can trigger notices. Prefer isset() to avoid noise in tests.
Apply this diff:
- if($responseBody['captchaToken']) { + if (isset($responseBody['captchaToken'])) { $this->assertArrayHasKey('captchaToken', $responseBody); $this->assertIsString($responseBody['captchaToken']); unset($responseBody['captchaToken']); }zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentConfirmControllerTest.php (1)
63-67: Use isset() when handling optional captchaTokenSame rationale as in AppointmentById test: avoid undefined index by guarding with isset().
Apply this diff:
- if($responseBody['captchaToken']) { + if (isset($responseBody['captchaToken'])) { $this->assertArrayHasKey('captchaToken', $responseBody); $this->assertIsString($responseBody['captchaToken']); unset($responseBody['captchaToken']); }
🧹 Nitpick comments (24)
zmscitizenview/src/utils/en-US.json (1)
128-129: Align terminology with domain model (“reservation” vs “session”) and tighten copyFrontend logic keys off reservationDuration (a reservation timer), while the header says “session”. Consider aligning the wording and making the body more concise.
If the German translations use “Reservierung,” mirror that for consistency. Suggested copy:
- "apiErrorSessionTimeoutHeader": "Your session has expired.", - "apiErrorSessionTimeoutText": "Too much time has passed since you started booking your appointment. Please select a new date to continue with the booking.", + "apiErrorSessionTimeoutHeader": "Your reservation has expired.", + "apiErrorSessionTimeoutText": "Your reservation expired due to inactivity. Please select a new date to continue booking.",zmscitizenapi/src/Zmscitizenapi/Models/ThinnedScope.php (1)
151-154: Add a simple guard to prevent negative durationsIf the schema allows only non-negative durations, enforce it defensively before validation.
$this->whitelistedMails = $whitelistedMails; $this->reservationDuration = $reservationDuration; + if ($this->reservationDuration !== null && $this->reservationDuration < 0) { + throw new InvalidArgumentException('reservationDuration must be >= 0'); + } $this->ensureValid();zmscitizenview/tests/unit/CustomerInfo.spec.ts (4)
11-13: Avoid any: add precise Ref types for stronger checksTighten typings to catch regressions at compile time.
- let mockAppointmentProvider: any; - let mockReservationStartMs: any; + import type { Ref } from "vue"; + let mockAppointmentProvider: { appointment: Ref<{ scope?: { reservationDuration?: number | null } } | null> }; + let mockReservationStartMs: Ref<number | null>;
69-73: Button stub: add type="button" to avoid implicit form submit side effectsPrevents accidental submits in environments where a form wrapper exists.
- '<button class="muc-button" :disabled="disabled" @click="$emit(\'click\')"><slot /></button>', + '<button type="button" class="muc-button" :disabled="disabled" @click="$emit(\'click\')"><slot /></button>',
84-87: Reduce brittleness in button lookupIndex-based selection is fragile. Prefer data-testid or role-based selectors exposed by the component.
Example:
const findNextButton = (wrapper: any) => wrapper.find('[data-testid="next"]'); const findBackButton = (wrapper: any) => wrapper.find('[data-testid="back"]');If component changes are undesirable, consider using more specific class selectors per button variant.
336-353: Stabilize time-dependent test and fix typosFreezing time removes flakiness. Also fix “Reservationtime” and “sre” typos in comments.
- it("displays the timeout message when the reservation time has expired", async () => { - // Reservationtime: 1 minute - mockAppointmentProvider.appointment.value = { scope: { reservationDuration: 1 } }; - mockReservationStartMs.value = Date.now() - 2 * 60 * 1000; + it("displays the timeout message when the reservation time has expired", async () => { + // Reservation time: 1 minute + // Freeze time to avoid drift + vi.useFakeTimers(); + vi.setSystemTime(new Date("2025-01-01T12:00:00Z")); + mockAppointmentProvider.appointment.value = { scope: { reservationDuration: 1 } }; + mockReservationStartMs.value = Date.now() - 2 * 60 * 1000; const wrapper = createWrapper(); await nextTick(); expect(wrapper.html()).toContain("apiErrorSessionTimeoutHeader"); expect(wrapper.html()).toContain("apiErrorSessionTimeoutText"); - // form and next-button sre not displayed + // form and next-button are not displayed expect(wrapper.find(".m-form").exists()).toBe(false); const buttons = wrapper.findAll(".m-button-group .muc-button"); expect(buttons.length).toBe(1); // only back-button + vi.useRealTimers(); });zmscitizenapi/tests/Zmscitizenapi/Controllers/Scope/ScopesListControllerTest.php (1)
111-113: Add non-nullreservationDurationtest coverage
It’s great that you mirrored the first (null) case in your second scope entry. However, to fully exercise the non-null path, consider adding at least one test wherereservationDurationis a concrete integer—similar to the existing positive case in the appointment tests.We’ve already confirmed a positive case here:
// zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentByIdControllerTest.php:106 "reservationDuration" => 15Please add a similar assertion in your ScopesListControllerTest. For example:
File:
zmscitizenapi/tests/Zmscitizenapi/Controllers/Scope/ScopesListControllerTest.php
Lines: 111–113"whitelistedMails" => null, - "reservationDuration" => null + "reservationDuration" => 30This will ensure both the null and non-null branches of
reservationDurationare covered.zmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficesListControllerTest.php (1)
143-145: Optional: Add a non-nullreservationDurationcase to OfficesListControllerTestA quick search shows only one non-null fixture for
reservationDurationin your tests—and it’s in the AppointmentByIdControllerTest, not in the OfficesListControllerTest:
- zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentByIdControllerTest.php:106:
"reservationDuration" => 15- In OfficesListControllerTest, both fixtures set
"reservationDuration" => null(no other positive cases found)If you’d like to catch any future mapping regressions in the OfficesList endpoint, consider adding at least one office fixture with a non-null integer value for
reservationDurationalongside the existing null cases.zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentConfirmControllerTest.php (1)
117-119: Align assertion style with other tests (optional)Other tests often use assertEqualsCanonicalizing for array responses. Not mandatory here, but consider consistency unless key order strictness is intentional.
Apply this diff if you want consistent canonicalizing across the suite:
- $this->assertEquals($expectedResponse, $responseBody); + $this->assertEqualsCanonicalizing($expectedResponse, $responseBody);zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentCancelControllerTest.php (1)
68-71: Reduce duplication for captcha token stripping across tests (optional)Multiple tests repeat the “if present, assert string and unset” pattern. Consider a small helper in the base test case to DRY this up.
I can draft a helper like stripCaptchaToken(array &$body): void in ControllerTestCase and update call sites if you want.
zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentPreconfirmControllerTest.php (1)
115-116: Reduce brittleness: prefer canonicalizing equality for associative arraysSwitching to assertEqualsCanonicalizing here would decouple the test from key order within associative arrays, aligning with other tests in this suite that already use canonicalizing assertions.
- $this->assertEquals($expectedResponse, $responseBody); + $this->assertEqualsCanonicalizing($expectedResponse, $responseBody);zmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficesServicesRelationsControllerTest.php (1)
89-91: Propagate reservationDuration in office scope responses — consistent with schema/modelAll four insertions look correct and keep reservationDuration adjacent to whitelistedMails. Given these arrays are asserted via assertEqualsCanonicalizing later, ordering is less fragile here, but keeping consistent placement aids readability and cross-file grepping.
- Consider adding a single positive test case (non-null reservationDuration) for an office to exercise MapperService::mapOfficesWithScope and verify propagation end-to-end.
- Optional: Extract a small helper to build the expected “scope” shape for offices to DRY up repeated structures across multiple tests.
Also applies to: 143-145, 253-255, 307-309
zmsentities/schema/citizenapi/thinnedScope.json (1)
116-123: Schema: add basic bounds to reservationDurationAdding reservationDuration is spot-on. To prevent invalid data, recommend constraining it to non-negative (or strictly positive) minutes. If “0” is not meaningful, use minimum: 1; otherwise minimum: 0.
"reservationDuration": { "type": [ "integer", "null" ], - "description": "Duration of the reservation in minutes" + "description": "Duration of the reservation in minutes", + "minimum": 1 }If “0” should mean “no time left” or “disabled,” change minimum to 0 and document the semantics.
zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentReserveControllerTest.php (1)
108-110: Reservation duration added to reserved appointment scope — matches API evolutionLooks good and consistent with the thinnedScope schema. This test already uses assertEqualsCanonicalizing (Line 119), which avoids order-coupling — keep that pattern.
If possible, add a variant where reservationDuration is a concrete integer to cover the happy-path countdown scenario.
zmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficeListByServiceControllerTest.php (1)
87-89: Include reservationDuration across service-filtered office scopesThe additions are consistent across both test blocks and align with the schema/model changes. Nice placement directly after whitelistedMails for consistency.
Given the repeated scope structures, consider a shared builder or fixture helper to construct the expected scope array. This keeps tests focused on behavior while easing future field additions.
Also applies to: 161-163, 212-214
zmscitizenview/src/utils/errorHandler.ts (2)
122-124: Normalize API error codes with underscores/hyphens before mapping (future-proof).If the backend ever emits
session_timeout,session-timeout, or mixed-case codes, the current mapping won’t hit. Normalizing to camelCase first makes the mapping more robust without affecting existing camelCase codes.Apply this diff to normalize the incoming error code prior to mapping:
- const errorStateKey = `apiError${errorCode.charAt(0).toUpperCase() + errorCode.slice(1)}`; + // Normalize snake_case/kebab-case to camelCase before building the state key + const normalized = errorCode.replace(/[_-](\w)/g, (_, c) => + c ? c.toUpperCase() : "" + ); + const errorStateKey = + "apiError" + normalized.charAt(0).toUpperCase() + normalized.slice(1);
156-171: Simplify redundant error-array checks.The three branches for
data.errorscan be collapsed to one fallback whenfirstErrorCodeis falsy. This is optional, but it shortens the function and follows KISS.A minimal refactor could be:
const firstErrorCode = data?.errors?.[0]?.errorCode ?? ""; - if (firstErrorCode) { - handleApiError(firstErrorCode, errorStates); - } else if (data.errors && data.errors.length > 0) { - errorStates.apiErrorGenericFallback.value = true; - } else if (data.errors && data.errors.length === 0) { - // Handle case where errors array exists but is empty - errorStates.apiErrorGenericFallback.value = true; - } + if (firstErrorCode) { + handleApiError(firstErrorCode, errorStates); + } else if (Array.isArray(data.errors)) { + errorStates.apiErrorGenericFallback.value = true; + }zmscitizenview/src/components/Appointment/AppointmentView.vue (1)
509-547: Optional: clear previous timer when starting a new reservation.If users reserve repeatedly within one session (e.g., rebooking loops), overwriting is fine. As a small polish, explicitly resetting
reservationStartMs.value = nullright before the new reservation starts can avoid any transient calculations if a consumer evaluates before the promise resolves.const nextReserveAppointment = () => { if (isReservingAppointment.value) { return; } isReservingAppointment.value = true; clearContextErrors(errorStateMap.value); captchaError.value = false; rebookOrCanelDialog.value = false; + // Reset any previous reservation timestamp until we get a new one + reservationStartMs.value = null;zmscitizenview/src/utils/useReservationTimer.ts (2)
4-4: Import watch to manage interval lifecycle based on expiry.We will use
watchto stop the interval once expired. This also supports the newtimeLeftStringaddition.-import { computed, inject, onBeforeUnmount, onMounted, ref } from "vue"; +import { computed, inject, onBeforeUnmount, onMounted, ref, watch } from "vue";
7-10: Defensive injects (optional): fail fast with clearer error if not provided.The non-null assertions will crash on destructuring if a provider is missing. Consider throwing an explicit error to aid debugging in non-embedded usage (e.g., isolated component tests).
- const { appointment } = inject<SelectedAppointmentProvider>("appointment")!; - const reservationStartMs = inject<Ref<number | null>>("reservationStartMs")!; + const apptProvider = inject<SelectedAppointmentProvider>("appointment"); + const reservationStartMs = inject<Ref<number | null>>("reservationStartMs"); + if (!apptProvider || !reservationStartMs) { + throw new Error("useReservationTimer requires 'appointment' and 'reservationStartMs' providers."); + } + const { appointment } = apptProvider;zmscitizenview/src/components/Appointment/AppointmentSummary.vue (1)
279-292: Hook usage is aligned; consider surfacing the countdown in the UI (optional).You already destructure
timeLeftStringfrom the hook. If desired, surface the remaining time in a subtle hint before expiration (e.g., as a small text near the booking button). If not needed, remove the unused binding to keep the file tidy.Minimal removal if you decide not to show the countdown:
-const { isExpired, timeLeftString } = useReservationTimer(); +const { isExpired } = useReservationTimer();zmscitizenapi/src/Zmscitizenapi/Services/Core/ZmsApiFacadeService.php (1)
95-127: Consider also exposing reservationDuration on Office for parity with other mappersMapperService::mapOfficesWithScope already sets reservationDuration on Office. For consistency of API projections across entry points, add it here too so consumers don’t have to special-case different endpoints.
Apply this minimal diff inside the Office constructor:
geo: $provider->data['geo'] ?? null, + reservationDuration: $rd, scope: $matchingScope ? new ThinnedScope(zmscitizenview/src/components/Appointment/CustomerInfo.vue (1)
121-121: Remove commented-out timer scaffold and unused importsPer Clean Code guidelines, avoid commented-out code and unused symbols. The logic now lives in useReservationTimer; keeping the scaffold increases noise.
Apply this diff to drop unused imports and the commented block:
-import { computed, inject, onBeforeUnmount, onMounted, ref, watch } from "vue"; +import { computed, inject, ref } from "vue"; @@ -// const { appointment } = inject<SelectedAppointmentProvider>("appointment")!; -// const reservationStartMs = inject<Ref<number | null>>("reservationStartMs")! -// -// /** Hilfsfunktion: beliebige Zeitrepräsentation -> ms seit Epoche */ -// const toMs = (ts: unknown): number | null => { -// if (ts == null) return null; -// if (typeof ts === "number") return ts < 1e12 ? ts * 1000 : ts; // Sekunden -> ms -// if (typeof ts === "string") { -// if (/^\d+$/.test(ts)) { -// const n = Number(ts); -// return Number.isFinite(n) ? (n < 1e12 ? n * 1000 : n) : null; -// } -// const d = new Date(ts).getTime(); // ISO-String -// return Number.isFinite(d) ? d : null; -// } -// return null; -// }; -// -// // Minuten aus appointment.scope.reservationDuration (ohne Defaults/Minima) -// const reservationDurationMinutes = computed<number | undefined>(() => { -// const raw: unknown = (appointment.value as any)?.scope?.reservationDuration; -// const n = typeof raw === "string" ? Number.parseInt(raw, 10) : (raw as number | undefined); -// return Number.isFinite(n as number) ? (n as number) : undefined; -// }); -// -// // Deadline = Start + rd * 60_000 -// const deadlineMs = computed<number | null>(() => { -// if (reservationStartMs.value == null || reservationDurationMinutes.value == null) return null; -// return reservationStartMs.value + reservationDurationMinutes.value * 60_000; -// }); -// -// // Sekündlicher Ticker -// const nowMs = ref(Date.now()); -// let timer: number | undefined; -// -// onMounted(() => { timer = window.setInterval(() => nowMs.value = Date.now(), 1000); }); -// onBeforeUnmount(() => { if (timer) window.clearInterval(timer); }); -// -// // Restzeit & Darstellung -// const remainingMs = computed<number | null>(() => -// deadlineMs.value == null ? null : Math.max(0, deadlineMs.value - nowMs.value) -// ); -// -// const timeLeftString = computed<string>(() => { -// if (remainingMs.value == null) return ""; -// const total = Math.floor(remainingMs.value / 1000); -// const m = Math.floor(total / 60); -// const s = total % 60; -// return `${m}:${s.toString().padStart(2, "0")}`; -// }); -// -// const isExpired = computed<boolean>(() => remainingMs.value !== null && remainingMs.value <= 0);Also applies to: 152-205
zmscitizenview/tests/unit/AppointmentSummary.spec.ts (1)
108-125: Stabilize date rendering by fixing the time zone for the date formatterThe time formatter already pins Europe/Berlin, but the date formatter relies on the environment’s default TZ. Pin it to avoid flakes around midnight or CI TZ differences.
Apply this diff:
- const formatterDate = new Intl.DateTimeFormat("de-DE", { + const formatterDate = new Intl.DateTimeFormat("de-DE", { + timeZone: "Europe/Berlin", weekday: "long", year: "numeric", month: "numeric", day: "numeric", });
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (24)
zmscitizenapi/src/Zmscitizenapi/Models/ThinnedScope.php(4 hunks)zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php(4 hunks)zmscitizenapi/src/Zmscitizenapi/Services/Core/ZmsApiFacadeService.php(11 hunks)zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentByIdControllerTest.php(1 hunks)zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentCancelControllerTest.php(1 hunks)zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentConfirmControllerTest.php(1 hunks)zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentPreconfirmControllerTest.php(1 hunks)zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentReserveControllerTest.php(1 hunks)zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentUpdateControllerTest.php(1 hunks)zmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficeListByServiceControllerTest.php(3 hunks)zmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficesListControllerTest.php(2 hunks)zmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficesServicesRelationsControllerTest.php(4 hunks)zmscitizenapi/tests/Zmscitizenapi/Controllers/Scope/ScopeByIdControllerTest.php(1 hunks)zmscitizenapi/tests/Zmscitizenapi/Controllers/Scope/ScopesListControllerTest.php(2 hunks)zmscitizenview/src/components/Appointment/AppointmentSummary.vue(7 hunks)zmscitizenview/src/components/Appointment/AppointmentView.vue(3 hunks)zmscitizenview/src/components/Appointment/CustomerInfo.vue(4 hunks)zmscitizenview/src/utils/de-DE.json(1 hunks)zmscitizenview/src/utils/en-US.json(1 hunks)zmscitizenview/src/utils/errorHandler.ts(1 hunks)zmscitizenview/src/utils/useReservationTimer.ts(1 hunks)zmscitizenview/tests/unit/AppointmentSummary.spec.ts(7 hunks)zmscitizenview/tests/unit/CustomerInfo.spec.ts(17 hunks)zmsentities/schema/citizenapi/thinnedScope.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*
⚙️ CodeRabbit configuration file
**/*: Apply the following Clean Code guidelines to all files, as summarized by wojteklu's Clean Code gist:Code is clean if it can be understood easily – by everyone on the team. Clean code can be read and enhanced by a developer other than its original author. With understandability comes readability, changeability, extensibility and maintainability.
General rules
- Follow standard conventions.
- Keep it simple stupid. Simpler is always better. Reduce complexity as much as possible.
- Boy scout rule. Leave the campground cleaner than you found it.
- Always find root cause. Always look for the root cause of a problem.
Design rules
- Keep configurable data at high levels.
- Prefer polymorphism to if/else or switch/case.
- Separate multi-threading code.
- Prevent over-configurability.
- Use dependency injection.
- Follow Law of Demeter. A class should know only its direct dependencies.
Understandability tips
- Be consistent. If you do something a certain way, do all similar things in the same way.
- Use explanatory variables.
- Encapsulate boundary conditions. Boundary conditions are hard to keep track of. Put the processing for them in one place.
- Prefer dedicated value objects to primitive type.
- Avoid logical dependency. Don't write methods which works correctly depending on something else in the same class.
- Avoid negative conditionals.
Names rules
- Choose descriptive and unambiguous names.
- Make meaningful distinction.
- Use pronounceable names.
- Use searchable names.
- Replace magic numbers with named constants.
- Avoid encodings. Don't append prefixes or type information.
Functions rules
- Small.
- Do one thing.
- Use descriptive names.
- Prefer fewer arguments.
- Have no side effects.
- Don't use flag arguments. Split method into several independent methods that can b...
Files:
zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentPreconfirmControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficesServicesRelationsControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentReserveControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentByIdControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentConfirmControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Scope/ScopeByIdControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentUpdateControllerTest.phpzmsentities/schema/citizenapi/thinnedScope.jsonzmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficeListByServiceControllerTest.phpzmscitizenview/src/utils/en-US.jsonzmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficesListControllerTest.phpzmscitizenview/src/utils/useReservationTimer.tszmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentCancelControllerTest.phpzmscitizenview/src/utils/errorHandler.tszmscitizenview/src/components/Appointment/AppointmentSummary.vuezmscitizenview/src/components/Appointment/CustomerInfo.vuezmscitizenview/tests/unit/AppointmentSummary.spec.tszmscitizenapi/src/Zmscitizenapi/Models/ThinnedScope.phpzmscitizenview/tests/unit/CustomerInfo.spec.tszmscitizenapi/tests/Zmscitizenapi/Controllers/Scope/ScopesListControllerTest.phpzmscitizenapi/src/Zmscitizenapi/Services/Core/ZmsApiFacadeService.phpzmscitizenview/src/components/Appointment/AppointmentView.vuezmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.phpzmscitizenview/src/utils/de-DE.json
**/*.php
⚙️ CodeRabbit configuration file
**/*.php: Flag any usage of error_log() as it should be replaced with proper Monolog logging mechanisms provided by zmsslim which should be setup in the App/Application of each module:
- For error handling: Use the proper Monolog logging framework with error levels
- For application info logs: Use the proper Monolog logging framework with info levels
- For debugging: Use a dedicated debug logger or remove debug statements
- For CLI output: Use a CLI output handler or symfony/console
- The application log levels are as follows DEBUG, INFO, NOTICE, WARNING, ERROR, CRITICAL, ALERT, and EMERGENCY
Example replacement:
// Instead of: error_log("Import failed - " . $e->getMessage()); // Use: $log->error("Import failed", ['error' => $e->getMessage()]);Flag specific logging violations:
- error_log(), var_dump(), print_r(), die(), exit() usage (except proper error logging in catch blocks)
- Any debug output that should use proper Monolog logging
- Debug constants like DEBUG = true
- Debug logging that should be removed in production
- Commented debug code that should be cleaned up
Example replacements:
// Instead of: error_log("Error occurred"); var_dump($data); die('debug point'); // Use: $log->error("Error occurred", ['context' => 'processing']); $log->debug('Data dump', ['data' => $data]); // Remove die() statements entirelyException handling should use proper logging:
// Instead of: try { $result = $this->process(); } catch (Exception $e) { error_log("Processing failed: " . $e->getMessage()); } // Use: try { $result = $this->process(); } catch (Exception $e) { $log->error("Processing failed", ['error' => $e->getMessage(), 'trace' => $e->getTraceAsString()]); } ```...
Files:
zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentPreconfirmControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficesServicesRelationsControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentReserveControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentByIdControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentConfirmControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Scope/ScopeByIdControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentUpdateControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficeListByServiceControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficesListControllerTest.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentCancelControllerTest.phpzmscitizenapi/src/Zmscitizenapi/Models/ThinnedScope.phpzmscitizenapi/tests/Zmscitizenapi/Controllers/Scope/ScopesListControllerTest.phpzmscitizenapi/src/Zmscitizenapi/Services/Core/ZmsApiFacadeService.phpzmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php
**/*.{js,jsx,ts,tsx}
⚙️ CodeRabbit configuration file
**/*.{js,jsx,ts,tsx}: Flag any usage of console.log() as it should be replaced with proper logging or removed:
- For development: console.debug()
- For production: Remove console.log() statements or use structured logging
- For errors: Use error console.error()
Example replacement:
// Instead of: console.log('User data:', userData); // Use: console.debug('Processing user data', { userData }); // or for development only: Remove the console.log entirelyFlag specific logging violations:
- console.log(), console.debug(), console.warn() usage (except console.error in catch blocks)
- Any debug output that should use proper logging frameworks
Example replacements:
// Instead of: console.log('User data:', userData); console.debug('Processing...'); // Use: // Remove console.log entirely or use proper logging // Only console.error in catch blocks is acceptable try { processData(userData); } catch (error) { console.error('Processing failed:', error); }Flag JavaScript security and UX issues:
- alert(), confirm(), prompt() usage (poor UX)
- eval() usage (security risk)
- innerHTML with user input (XSS risk)
- Unfiltered user input in DOM manipulation
Example replacements:
// Instead of: alert('Error occurred'); eval(userInput); // Use: // Use proper error handling and UI components this.showErrorNotification('Error occurred'); // Avoid eval() entirelyFlag TODO/FIXME comments that indicate technical debt:
- TODO comments without clear action items
- FIXME comments indicating broken functionality
- HACK comments indicating temporary workarounds
- XXX comments indicating problematic code
These should be converted to proper issues or addressed:
// Instead of: // TODO: fix this later // FIXME: this is broken // Use: // Create proper issue and reference it // @see Issue #123: Refactor validation logicFlag code complexity issues:
- Functions longer than 50 lines
- Deep nesting (...
Files:
zmscitizenview/src/utils/useReservationTimer.tszmscitizenview/src/utils/errorHandler.tszmscitizenview/tests/unit/AppointmentSummary.spec.tszmscitizenview/tests/unit/CustomerInfo.spec.ts
🧬 Code graph analysis (4)
zmscitizenview/src/utils/useReservationTimer.ts (1)
zmscitizenview/src/types/ProvideInjectTypes.ts (1)
SelectedAppointmentProvider(22-24)
zmscitizenapi/src/Zmscitizenapi/Models/ThinnedScope.php (4)
zmscitizenapi/src/Zmscitizenapi/Models/Office.php (1)
__construct(29-58)zmscitizenapi/src/Zmscitizenapi/Models/ThinnedProvider.php (2)
__construct(28-38)ThinnedProvider(11-69)zmscitizenapi/src/Zmscitizenapi/Models/ThinnedProcess.php (1)
__construct(52-73)zmscitizenapi/src/Zmscitizenapi/Models/Collections/ThinnedScopeList.php (1)
__construct(17-32)
zmscitizenapi/src/Zmscitizenapi/Services/Core/ZmsApiFacadeService.php (1)
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php (2)
MapperService(35-489)extractReservationDuration(54-59)
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php (3)
zmsentities/src/Zmsentities/Scope.php (1)
Scope(11-375)zmscitizenapi/src/Zmscitizenapi/Models/ThinnedScope.php (1)
ThinnedScope(12-185)zmsentities/src/Zmsentities/Schema/Entity.php (1)
toProperty(264-267)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (34)
zmscitizenapi/src/Zmscitizenapi/Models/ThinnedScope.php (3)
33-33: New nullable property looks correct and is backwards compatibleAdding
public ?int $reservationDuration = null;is fine and matches the intended semantics.
35-56: Constructor extension verified—no action needed
Allnew ThinnedScope(...)invocations either use named arguments or rely on the no-arg default constructor. Appending?int $reservationDuration = nullat the end preserves backward compatibility, and there are no positional-style calls to refactor.
156-178: reservationDuration in schema confirmed
Thezmsentities/schema/citizenapi/thinnedScope.jsonfile already declares thereservationDurationproperty with:
- type:
integer | null- description: “Duration of the reservation in minutes”
No further schema changes are needed—serialization and schema remain in lockstep.
zmscitizenview/tests/unit/CustomerInfo.spec.ts (1)
48-59: Injection keys align with component usageI’ve verified that CustomerInfo.vue uses plain string keys for injection—
"customerData","selectedTimeslot", and"loadingStates"—and the unit test’sprovideblock uses those exact same strings. The commented-out injections forappointmentandreservationStartMsin the component don’t impact resolution (they’re currently unused), so no changes to the spec’s provide keys are needed.zmscitizenapi/tests/Zmscitizenapi/Controllers/Scope/ScopesListControllerTest.php (1)
74-76: Expected shape updated correctly with reservationDuration => nullMatches the model change; assertion uses canonicalizing equality, so order is fine.
zmscitizenapi/tests/Zmscitizenapi/Controllers/Office/OfficesListControllerTest.php (1)
89-91: Office.scope now includes reservationDuration; looks consistentThe added field aligns with ThinnedScope serialization.
zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentUpdateControllerTest.php (1)
105-106: Addition of scope.reservationDuration in expected response looks correctThe new field is placed consistently after whitelistedMails and matches the schema/type (integer|null). No issues spotted.
zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentByIdControllerTest.php (1)
105-107: Verify the origin of the hard-coded “15” for reservationDurationI wasn’t able to find a JSON fixture or mapping in zmscitizenapi tests that explicitly defines
"reservationDuration" => 15. That value likely comes from a default in your mapping or facade layer (e.g. an AppointmentMapper or the fixture setup inzmscitizenapi/src/...). To avoid brittle tests, please:• Locate where
reservationDurationis set to 15 in the production code
– e.g. inspectsrc/Zmscitizenapi/Mappers/AppointmentMapper.php(or similar) for a default15
• Ensure that fixture data (if used) and mapping defaults are versioned/stable
– if it’s a config value, consider extracting it into a constant (e.g.const DEFAULT_RESERVATION_DURATION = 15;) and reference that in both code and tests
• Update the test to reference the same constant or to load the fixture so the source of truth is unifiedBy confirming the source of
15and tying your test to that constant/fixture, you’ll prevent future breaks if the default ever changes.zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentConfirmControllerTest.php (1)
106-108: reservationDuration added to expected scope — aligned with schema and other testsPlacement and null expectation are consistent. Looks good.
zmscitizenapi/tests/Zmscitizenapi/Controllers/Scope/ScopeByIdControllerTest.php (1)
73-75: Confirmed: reservationDuration property correctly defined in JSON schemaThe
thinnedScope.jsonschema atschema/citizenapi/thinnedScope.jsonincludes areservationDurationproperty with type["integer","null"]and the expected description, matching the null expectation in the test fixture. No further changes required.zmscitizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentCancelControllerTest.php (1)
109-111: reservationDuration addition in expected scope — consistent and correctMatches the updated contract; test remains clear.
zmscitizenview/src/utils/errorHandler.ts (1)
65-65: Add session-timeout error key — looks correct and consistent.The new
apiErrorSessionTimeoutkey aligns with the dynamic mapping inhandleApiErrorand with the translation keys pattern (<ErrorStateName>Header/Text). No issues.zmscitizenview/src/utils/de-DE.json (2)
128-129: German translations for session timeout — good wording and tone.The keys and phrasing match the error state and are consistent with the rest of the locale file.
1-224: Localization parity verified forapiErrorSessionTimeoutkeys
The keysapiErrorSessionTimeoutHeaderandapiErrorSessionTimeoutTextare present exactly once in bothde-DE.jsonanden-US.json, with no duplicates detected.zmscitizenview/src/components/Appointment/AppointmentView.vue (3)
365-366: Introduce reservationStartMs state — correct typing and initialization.Providing a
Ref<number|null>here is appropriate and keeps the timer opt-in until a reservation is made.
435-436: Provide reservationStartMs to descendants — enables timer hook integration.Providing via the injection key is consistent with the existing provide/inject usage in this component.
527-535: Start timer upon successful reservation — timing is correctly captured.Setting
reservationStartMsimmediately after receiving a validprocessIdis the right trigger. This ensures CustomerInfo/AppointmentSummary can gate UI on expiration right away.zmscitizenview/src/components/Appointment/AppointmentSummary.vue (2)
2-9: Clear, user-friendly session-timeout callout.Showing a dedicated callout on expiry with the new translation keys is exactly what users need here.
10-13: Correct gating of interactive UI when expired.Wrapping the details and action groups with
!isExpiredprevents invalid interactions post-timeout while still allowing navigation (e.g., Back) where appropriate.Also applies to: 210-216, 231-232, 264-264
zmscitizenapi/src/Zmscitizenapi/Services/Core/ZmsApiFacadeService.php (5)
94-125: LGTM: Correctly extracting and threading reservationDuration into ThinnedScope for officesComputing $rd once and passing it through to the nested ThinnedScope is clean and avoids repeated property traversal.
161-182: LGTM: Scopes projection now includes reservationDurationGood reuse of MapperService::extractReservationDuration and consistent serialization alongside whitelistedMails.
276-318: LGTM: getScopeByOfficeId returns reservationDuration consistentlyThe intermediate $result array keeps the mapping readable while adding reservationDuration. No concerns.
429-450: LGTM: getScopeById includes reservationDuration in ThinnedScopeStraightforward propagation; matches other endpoints.
712-733: LGTM: ThinnedProcess.scope carries reservationDurationCorrectly extracts from process->scope and threads through to the client-visible model.
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php (3)
81-82: LGTM: Precomputing reservationDuration for Office mappingReads once and passes through to both Office and nested ThinnedScope mapping. Once the extractor is fixed, this is robust.
113-115: LGTM: ThinnedScope in Office mapping now includes reservationDurationConsistent with schema and other mappers.
255-257: LGTM: scopeToThinnedScope adds reservationDuration via MapperService extractorKeeps model construction centralized and consistent. After the extractor fix, this covers both entity origins.
zmscitizenview/src/components/Appointment/CustomerInfo.vue (3)
2-9: Nice UX: Explicit timeout callout when the session expiresClear, localized messaging via MucCallout aligns with the PR’s objective. Good separation from the main form.
11-20: Solid gating of interactive UI on expirationGuarding the heading, form, and Next button with v-if="!isExpired" prevents unintended interactions post-timeout.
Also applies to: 96-96
123-151: Adoption of useReservationTimer is appropriateInjecting isExpired/timeLeftString keeps the component lean and shifts time logic to a dedicated composable.
zmscitizenview/tests/unit/AppointmentSummary.spec.ts (4)
14-49: LGTM: Comprehensive test scaffolding for services, provider, appointment, and timer startThe beforeEach setup is clear and supports the new timeout scenarios without over-mocking.
73-82: LGTM: Improved muc-button and muc-callout stubsRicher stubs (data-icon, disabled) make downstream assertions precise and resilient.
88-90: LGTM: Helper for icon-based button queriesfindButtonByIcon reduces duplication and improves test intent readability.
318-336: LGTM: Session timeout test validates both UX messaging and UI gatingGood coverage: asserts header/text visibility, hides main content, and ensures only back navigation is available.
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php
Outdated
Show resolved
Hide resolved
...tizenapi/tests/Zmscitizenapi/Controllers/Appointment/AppointmentPreconfirmControllerTest.php
Show resolved
Hide resolved
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php (1)
54-66: Resolved: safe extraction for both Scope and ThinnedScopeThe previous fatal due to calling toProperty() on ThinnedScope is correctly fixed with an instanceof split. Union types and imports are in order. Nice.
🧹 Nitpick comments (5)
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php (5)
63-65: Drop redundant nullsafe on $scope in the Scope branchAt this point $scope cannot be null (you returned earlier and handled ThinnedScope). Using ?-> on $scope slightly obscures intent.
Apply:
- $v = $scope?->toProperty()?->preferences?->appointment?->reservationDuration?->get(); + $v = $scope->toProperty()?->preferences?->appointment?->reservationDuration?->get();
87-87: Use a descriptive variable namerd is cryptic. Use reservationDuration for readability and consistency with the constructor argument below.
- $rd = self::extractReservationDuration($providerScope); + $reservationDuration = self::extractReservationDuration($providerScope);
246-263: Prefer self:: over MapperService:: for intra-class static callsLine 263 uses the class name while Line 87 uses self::. Pick one convention; self:: is idiomatic and eases refactors.
- reservationDuration: MapperService::extractReservationDuration($scope), + reservationDuration: self::extractReservationDuration($scope),
246-263: Avoid casting before null-coalescing: emailFrom becomes '' instead of nullLine 247 casts to string before ?? null, which turns null into '' and defeats the null default. If emailFrom is absent you probably want null, not an empty string.
- emailFrom: (string) $scope->getEmailFrom() ?? null, + emailFrom: $scope->getEmailFrom(),Rationale: ThinnedScope::emailFrom is ?string, so passing through the nullable getter is sufficient and clearer.
119-121: Use a descriptive variable name for reservationDuration
Rename the short$rdto$reservationDurationat the callsite to make the intent clear.• File:
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.phparound line 120
• Change the constructor call to pass the renamed variable:- whitelistedMails: isset($providerScope->whitelistedMails) ? ((string) $providerScope->whitelistedMails === '' ? null : (string) $providerScope->whitelistedMails) : null, - reservationDuration: $rd, + whitelistedMails: isset($providerScope->whitelistedMails) ? ((string) $providerScope->whitelistedMails === '' ? null : (string) $providerScope->whitelistedMails) : null, + reservationDuration: $reservationDuration,
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php(4 hunks)zmscitizenview/src/utils/useReservationTimer.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- zmscitizenview/src/utils/useReservationTimer.ts
🧰 Additional context used
📓 Path-based instructions (2)
**/*
⚙️ CodeRabbit configuration file
**/*: Apply the following Clean Code guidelines to all files, as summarized by wojteklu's Clean Code gist:Code is clean if it can be understood easily – by everyone on the team. Clean code can be read and enhanced by a developer other than its original author. With understandability comes readability, changeability, extensibility and maintainability.
General rules
- Follow standard conventions.
- Keep it simple stupid. Simpler is always better. Reduce complexity as much as possible.
- Boy scout rule. Leave the campground cleaner than you found it.
- Always find root cause. Always look for the root cause of a problem.
Design rules
- Keep configurable data at high levels.
- Prefer polymorphism to if/else or switch/case.
- Separate multi-threading code.
- Prevent over-configurability.
- Use dependency injection.
- Follow Law of Demeter. A class should know only its direct dependencies.
Understandability tips
- Be consistent. If you do something a certain way, do all similar things in the same way.
- Use explanatory variables.
- Encapsulate boundary conditions. Boundary conditions are hard to keep track of. Put the processing for them in one place.
- Prefer dedicated value objects to primitive type.
- Avoid logical dependency. Don't write methods which works correctly depending on something else in the same class.
- Avoid negative conditionals.
Names rules
- Choose descriptive and unambiguous names.
- Make meaningful distinction.
- Use pronounceable names.
- Use searchable names.
- Replace magic numbers with named constants.
- Avoid encodings. Don't append prefixes or type information.
Functions rules
- Small.
- Do one thing.
- Use descriptive names.
- Prefer fewer arguments.
- Have no side effects.
- Don't use flag arguments. Split method into several independent methods that can b...
Files:
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php
**/*.php
⚙️ CodeRabbit configuration file
**/*.php: Flag any usage of error_log() as it should be replaced with proper Monolog logging mechanisms provided by zmsslim which should be setup in the App/Application of each module:
- For error handling: Use the proper Monolog logging framework with error levels
- For application info logs: Use the proper Monolog logging framework with info levels
- For debugging: Use a dedicated debug logger or remove debug statements
- For CLI output: Use a CLI output handler or symfony/console
- The application log levels are as follows DEBUG, INFO, NOTICE, WARNING, ERROR, CRITICAL, ALERT, and EMERGENCY
Example replacement:
// Instead of: error_log("Import failed - " . $e->getMessage()); // Use: $log->error("Import failed", ['error' => $e->getMessage()]);Flag specific logging violations:
- error_log(), var_dump(), print_r(), die(), exit() usage (except proper error logging in catch blocks)
- Any debug output that should use proper Monolog logging
- Debug constants like DEBUG = true
- Debug logging that should be removed in production
- Commented debug code that should be cleaned up
Example replacements:
// Instead of: error_log("Error occurred"); var_dump($data); die('debug point'); // Use: $log->error("Error occurred", ['context' => 'processing']); $log->debug('Data dump', ['data' => $data]); // Remove die() statements entirelyException handling should use proper logging:
// Instead of: try { $result = $this->process(); } catch (Exception $e) { error_log("Processing failed: " . $e->getMessage()); } // Use: try { $result = $this->process(); } catch (Exception $e) { $log->error("Processing failed", ['error' => $e->getMessage(), 'trace' => $e->getTraceAsString()]); } ```...
Files:
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php
🧬 Code graph analysis (1)
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php (2)
zmsdb/src/Zmsdb/Query/Scope.php (1)
Scope(5-457)zmscitizenapi/src/Zmscitizenapi/Models/ThinnedScope.php (2)
ThinnedScope(12-185)getReservationDuration(151-154)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: call-php-unit-tests / zmsdb-test
- GitHub Check: call-php-unit-tests / zmsapi-test
zmscitizenapi/src/Zmscitizenapi/Services/Core/MapperService.php
Outdated
Show resolved
Hide resolved
Pull Request Checklist (Feature Branch to
next):nextBranch in meinen Feature-Branch gemergt.Summary by CodeRabbit
New Features
Error Handling
Localization
Schema
Tests