Skip to content

[fix] revert all breaking syntax changes #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[fix] revert all breaking syntax changes #154

wants to merge 1 commit into from

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Feb 11, 2022

Fixes #153.

@ljharb
Copy link
Contributor Author

ljharb commented Feb 11, 2022

there ended up being a bunch of things - conversions of var to const, arrow functions, rest/spread argument syntax, so i reverted all that back without changing the semantics.

@ljharb ljharb changed the title [fix] use normal function instead of an arrow function [fix] revert all breaking syntax changes Feb 11, 2022
@isaacs isaacs closed this in 20b4b56 Feb 12, 2022
isaacs pushed a commit that referenced this pull request Feb 12, 2022
@ljharb @isaacs
[fix] revert all breaking syntax changes
36932e0 
Fixes #153.

PR-URL: #154
Credit: @ljharb
Close: #154
Reviewed-by: @isaacs
@ljharb ljharb deleted the patch-1 branch February 13, 2022 00:26
afzalimdad9 added a commit to afzalimdad9/minimatch that referenced this pull request Jan 18, 2025
@afzalimdad9
[fix] revert all breaking syntax changes
882792f 
Fixes #153.

PR-URL: isaacs/minimatch#154
Credit: @ljharb
Close: #154
Reviewed-by: @isaacs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

breaking change in minimatch v3.0.5
1 participant
@ljharb