replace PathIcon with Button in ClosableTag #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ClosableTag component by replacing the PathIcon close button with a Button to improve design and functionality while simplifying command handling logic.
- Replaces PathIcon with Button and updates the TemplatePart attribute.
- Simplifies OnApplyTemplate by removing PointerPressed logic in favor of Button command binding.
- Adds design preview and new Button styles for hover and pressed states.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Ursa/Controls/TagInput/ClosableTag.cs | Updated TemplatePart attribute and simplified event handling logic by replacing PathIcon with Button. |
| src/Ursa.Themes.Semi/Controls/TagInput.axaml | Updated control template and added design preview plus new hover/pressed styles for the close Button. |
|
Why do we need to make this change? |
rabbitism
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
ClosableTagcomponent in theTagInputcontrol to improve its design and functionality. The key changes include replacing thePathIconclose button with aButton, updating styles for hover and pressed states, and simplifying the command handling logic.Design and UI Improvements:
ClosableTagcomponent inTagInput.axamlto enhance development and visualization. (src/Ursa.Themes.Semi/Controls/TagInput.axaml, src/Ursa.Themes.Semi/Controls/TagInput.axamlR5-R7)ClosableTagtemplate to replace thePathIconclose button with a styledButton, improving customization and usability. (src/Ursa.Themes.Semi/Controls/TagInput.axaml, src/Ursa.Themes.Semi/Controls/TagInput.axamlL118-R137)src/Ursa.Themes.Semi/Controls/TagInput.axaml, src/Ursa.Themes.Semi/Controls/TagInput.axamlR149-R154)Codebase Simplification:
TemplatePartattribute inClosableTag.csto reflect the replacement ofPathIconwithButton. (src/Ursa/Controls/TagInput/ClosableTag.cs, src/Ursa/Controls/TagInput/ClosableTag.csL6-R14)OnApplyTemplatemethod by removing thePointerPressedevent handling logic, as theButtonnow directly supports commands. (src/Ursa/Controls/TagInput/ClosableTag.cs, src/Ursa/Controls/TagInput/ClosableTag.csL27-R27)