This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Clamp audio slider between 0 - 2 #10854
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
suggested changes
Aug 4, 2024
| <InputGroup name="Volume" label={t('editor:properties.media.lbl-volume')} className="w-auto"> | ||
| <Slider | ||
| min={0} | ||
| max={100} |
Contributor
There was a problem hiding this comment.
wouldn't it be better to change the min/max/step ?
Contributor
Author
There was a problem hiding this comment.
the min max is for the slider UI, is we want the values to be between 0 - 100 on the UI
, we need to use a converter
to convert between 0-2 on the audio scale to 0 - 100 on the UI
Contributor
Author
There was a problem hiding this comment.
we can keep the values between 0 - 2 on the UI as well, if needed, is that preffered?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The audio slider in the MediaNodeEditor component was not properly clamped between the values of 0 and 2. This pull request fixes that issue by adding a clamp function to ensure the slider value stays within the desired range.