fix: ipfs.dns → ipfs.resolve #1302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
approved these changes
Nov 8, 2023
Member
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
SGTM, were you able to test this with a local build?
ipfs.dns is deprecated, and broken in Kubo 0.24: ipfs/kubo#10212
lidel
force-pushed
the
fix/webui-preload-kubo-0.24
branch
from
9adfe5c to
2df0aac
Compare
Member
Author
|
@SgtPooki pushed fix, But it does not really matter, even if that failed in Kubo 0.24, the fallback based on pathname detection still works and preloads ok: |
SgtPooki
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix webui preload in Kubo 0.24.
Context:
ipfs.dnshas been deprecated for a while, and the way we use it here got broken in Kubo 0.24: ipfs/kubo#10212