Merge pull request #261 from mattjala/chronomcp_tests

JaimeCernuda · web-flow · commit f5249a98a80b · 2025-08-21T16:41:32.000-04:00
Add ChronoLog MCP unit tests
diff --git a/.github/workflows/quality_control.yml b/.github/workflows/quality_control.yml
@@ -6,6 +6,10 @@ on:
   pull_request:
     branches: [ main, dev, integration-cleanup, update-workflow-with-correct-code-security ]
 
+# Chronolog MCP tests are handled in dedicated workflow
+env:
+  NO_TEST_MCPS: '["Chronolog"]'
+
 jobs:
   discover-mcps:
     name: Discover MCP Directories
@@ -116,6 +120,7 @@ jobs:
     name: Test - ${{ matrix.mcp }}
     runs-on: ubuntu-latest
     needs: discover-mcps
+    if: ${{ !contains(fromJson(env.NO_TEST_MCPS), matrix.mcp) }}
     strategy:
       fail-fast: false
       matrix:
@@ -211,6 +216,7 @@ jobs:
     name: Python 3.10 - ${{ matrix.mcp }}
     runs-on: ubuntu-latest
     needs: discover-mcps
+    if: ${{ !contains(fromJson(env.NO_TEST_MCPS), matrix.mcp) }}
     strategy:
       fail-fast: false
       matrix:
@@ -250,6 +256,7 @@ jobs:
     name: Python 3.11 - ${{ matrix.mcp }}
     runs-on: ubuntu-latest
     needs: discover-mcps
+    if: ${{ !contains(fromJson(env.NO_TEST_MCPS), matrix.mcp) }}
     strategy:
       fail-fast: false
       matrix:
@@ -289,6 +296,7 @@ jobs:
     name: Python 3.12 - ${{ matrix.mcp }}
     runs-on: ubuntu-latest
     needs: discover-mcps
+    if: ${{ !contains(fromJson(env.NO_TEST_MCPS), matrix.mcp) }}
     strategy:
       fail-fast: false
       matrix:
diff --git a/.github/workflows/test-chronomcp.yml b/.github/workflows/test-chronomcp.yml
@@ -0,0 +1,119 @@
+
+name: Test ChronoLog MCP
+
+on:
+  push:
+    branches: [ main, dev ]
+
+  pull_request:
+    branches: [ main, dev ]
+
+  workflow_dispatch:
+
+jobs:
+  test-chronomcp:
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+      
+    - name: Set up Python
+      uses: actions/setup-python@v4
+      with:
+        python-version: '3.12'
+        
+    - name: Install uv
+      uses: astral-sh/setup-uv@v3
+      
+    - name: Install gcc13 at runner level
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y gcc-13 g++-13 gfortran-13
+        
+    - name: Get spack
+      run: |
+        git clone --branch v0.21.2 https://github.com/spack/spack.git
+        source spack/share/spack/setup-env.sh
+        echo "SPACK_ROOT=$PWD/spack" >> $GITHUB_ENV
+        echo "$PWD/spack/bin" >> $GITHUB_PATH
+        # Prevent spack from auto-detecting system compilers (including gcc14)
+        spack compiler remove --all || true
+        
+    - name: Clone ChronoLog repository
+      run: |
+        git clone https://github.com/grc-iit/ChronoLog.git
+        cd ChronoLog
+        git switch develop
+        
+    - name: Cache Spack Dependencies
+      uses: actions/cache@v4
+      id: spack-cache
+      with:
+        path: |
+          ${{ env.SPACK_ROOT }}/opt
+          ${{ env.SPACK_ROOT }}/var/spack/cache
+          ~/.spack
+          ${{ github.workspace }}/ChronoLog/.spack-env
+        key: chronolog-spack-${{ runner.os }}-${{ hashFiles('ChronoLog/spack.yaml') }}
+        restore-keys: |
+          chronolog-spack-${{ runner.os }}-
+
+    - name: Install ChronoLog dependencies
+      if: steps.spack-cache.outputs.cache-hit != 'true'
+      working-directory: ${{ github.workspace }}/ChronoLog
+      run: |
+        source $SPACK_ROOT/share/spack/setup-env.sh
+        spack env activate -p .
+        # Register gcc-13 with Spack and remove any gcc-14 to avoid libffi incompatibility
+        spack compiler find /usr/bin
+        spack compiler remove gcc@14 --all || true
+        spack concretize --force
+        spack install -j4 -v
+        
+    - name: Setup Spack Environment (Cache Hit)
+      if: steps.spack-cache.outputs.cache-hit == 'true'
+      working-directory: ${{ github.workspace }}/ChronoLog
+      run: |
+        source $SPACK_ROOT/share/spack/setup-env.sh
+        spack env activate -p .
+        
+    - name: Build ChronoLog
+      working-directory: ${{ github.workspace }}/ChronoLog
+      run: |
+        source $SPACK_ROOT/share/spack/setup-env.sh
+        spack env activate -p .
+        ./deploy/local_single_user_deploy.sh --build --build-type Debug --install-dir $GITHUB_WORKSPACE/ChronoLog/install
+        
+    - name: Install ChronoLog
+      working-directory: ${{ github.workspace }}/ChronoLog
+      run: |
+        source $SPACK_ROOT/share/spack/setup-env.sh
+        spack env activate -p .
+        ./deploy/local_single_user_deploy.sh --install --work-dir $GITHUB_WORKSPACE/ChronoLog/install/Debug
+        echo "PYTHONPATH=$PYTHONPATH:$GITHUB_WORKSPACE/ChronoLog/install/Debug/lib" >> $GITHUB_ENV
+        echo "LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$GITHUB_WORKSPACE/ChronoLog/install/Debug/lib" >> $GITHUB_ENV
+
+    - name: Create Python client symlink
+      working-directory: ${{ github.workspace }}/ChronoLog/install/Debug/lib
+      run: |
+        rm -f py_chronolog_client.so
+        ln -s py_chronolog_client.cpython-312-x86_64-linux-gnu.so py_chronolog_client.so
+
+    - name: Start ChronoLog service
+      working-directory: ${{ github.workspace }}/ChronoLog
+      run: |
+        source $SPACK_ROOT/share/spack/setup-env.sh
+        spack env activate -p .
+        ./deploy/local_single_user_deploy.sh -d -k 5 -r 2 --work-dir $GITHUB_WORKSPACE/ChronoLog/install/Debug
+        
+    - name: Install ChronoLog MCP dependencies
+      working-directory: ${{ github.workspace }}/mcps/Chronolog
+      run: |
+        uv venv
+        uv sync --python 3.11
+        uv pip install -e .
+        
+    - name: Run ChronoLog MCP tests
+      working-directory: ${{ github.workspace }}/mcps/Chronolog
+      run: uv run pytest -v
diff --git a/.github/workflows/test-mcps.yml b/.github/workflows/test-mcps.yml
@@ -17,8 +17,6 @@ jobs:
             path: "mcps/Adios"
           - name: "Arxiv" 
             path: "mcps/Arxiv"
-          - name: "Chronolog"
-            path: "mcps/Chronolog"
           - name: "Compression"
             path: "mcps/Compression"
           - name: "Darshan"
diff --git a/mcps/Chronolog/pyproject.toml b/mcps/Chronolog/pyproject.toml
@@ -29,7 +29,13 @@ dependencies = [
     "fastmcp",
     "python-dotenv",
     "google-genai",
-    "h5py"
+    "h5py",
+    "pytest",
+    "pytest-asyncio",
+    "h11>=0.16.0",
+    "requests>=2.32.4",
+    "starlette>=0.47.2",
+    "urllib3>=2.5.0"
 ]
 
 [project.scripts]
diff --git a/mcps/Chronolog/src/chronomcp/capabilities/record_handler.py b/mcps/Chronolog/src/chronomcp/capabilities/record_handler.py
@@ -1,5 +1,6 @@
 # capabilities/record_interaction.py
-import utils.config as config
+
+from chronomcp.utils import config
 
 
 async def record_interaction(user_message: str, assistant_message: str) -> str:
diff --git a/mcps/Chronolog/src/chronomcp/capabilities/retrieve_handler.py b/mcps/Chronolog/src/chronomcp/capabilities/retrieve_handler.py
@@ -1,8 +1,8 @@
 # capabilities/retrieve_interaction.py
-import utils.config as config
-import utils.helpers as helpers
+
 import re
 from datetime import datetime
+from chronomcp.utils import config, helpers
 
 
 async def retrieve_interaction(
diff --git a/mcps/Chronolog/src/chronomcp/capabilities/start_handler.py b/mcps/Chronolog/src/chronomcp/capabilities/start_handler.py
@@ -1,5 +1,6 @@
 # capabilities/start_chronolog.py
-import utils.config as config
+
+from chronomcp.utils import config
 
 
 async def start_chronolog(
diff --git a/mcps/Chronolog/src/chronomcp/capabilities/stop_handler.py b/mcps/Chronolog/src/chronomcp/capabilities/stop_handler.py
@@ -1,5 +1,6 @@
 # capabilities/stop_chronolog.py
-import utils.config as config
+
+from chronomcp.utils import config
 
 
 async def stop_chronolog() -> str:
diff --git a/mcps/Chronolog/src/chronomcp/utils/config.py b/mcps/Chronolog/src/chronomcp/utils/config.py
@@ -36,6 +36,6 @@
 mcp: FastMCP = FastMCP("chronologMCP")
 
 # session state
-_active_chronicle = None
-_active_story = None
+_active_chronicle = ""
+_active_story = ""
 _story_handle = None
diff --git a/mcps/Chronolog/tests/__init__.py b/mcps/Chronolog/tests/__init__.py
diff --git a/mcps/Chronolog/tests/test_helpers.py b/mcps/Chronolog/tests/test_helpers.py
@@ -0,0 +1,41 @@
+"""Tests for Chronolog utility helper functions."""
+
+import pytest
+import sys
+import os
+
+# Add src to path for testing
+sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
+
+from chronomcp.utils.helpers import parse_time_arg
+from .test_utils import are_chronolog_processes_running
+
+
+class TestHelpers:
+    """Test utility helper functions"""
+
+    def test_parse_time_arg_with_digits(self):
+        """Test parsing numeric time arguments"""
+        if not are_chronolog_processes_running():
+            pytest.skip("ChronoLog processes are not running")
+
+        result = parse_time_arg("1672574400000000000", False)
+        assert result == "1672574400000000000"
+
+    def test_parse_time_arg_today(self):
+        """Test parsing 'today' keyword"""
+        if not are_chronolog_processes_running():
+            pytest.skip("ChronoLog processes are not running")
+
+        result = parse_time_arg("today", False)
+        assert isinstance(result, str)
+        assert result.isdigit()
+
+    def test_parse_time_arg_iso_format(self):
+        """Test parsing ISO format dates"""
+        if not are_chronolog_processes_running():
+            pytest.skip("ChronoLog processes are not running")
+
+        result = parse_time_arg("2023-01-15", False)
+        assert isinstance(result, str)
+        assert result.isdigit()
diff --git a/mcps/Chronolog/tests/test_integration.py b/mcps/Chronolog/tests/test_integration.py
@@ -0,0 +1,55 @@
+"""Integration tests for Chronolog MCP Server."""
+
+import pytest
+import sys
+import os
+import time
+import random
+
+# Add src to path for testing
+sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
+
+from chronomcp.capabilities import (
+    record_handler,
+    retrieve_handler,
+    start_handler,
+    stop_handler,
+)
+from .test_utils import are_chronolog_processes_running
+
+
+class TestIntegration:
+    """Integration tests for the full Chronolog MCP stack"""
+
+    @pytest.mark.asyncio
+    async def test_basic_workflow(self):
+        """Test basic workflow: start -> record -> retrieve -> stop"""
+        if not are_chronolog_processes_running():
+            pytest.skip("ChronoLog processes are not running")
+
+        chronicle_name = (
+            f"test_chronicle_{int(time.time())}_{random.randint(1000, 9999)}"
+        )
+        story_name = f"test_story_{int(time.time())}_{random.randint(1000, 9999)}"
+
+        # Start session
+        start_result = await start_handler.start_chronolog(chronicle_name, story_name)
+        assert isinstance(start_result, str)
+        assert "ChronoLog session started" in start_result
+
+        # Record interaction
+        record_result = await record_handler.record_interaction("Hello", "Hi there!")
+        assert isinstance(record_result, str)
+        assert record_result == "Interaction recorded to ChronoLog"
+
+        # Retrieve interactions
+        retrieve_result = await retrieve_handler.retrieve_interaction(
+            chronicle_name, story_name
+        )
+        assert isinstance(retrieve_result, str)
+        assert "Not records found." not in retrieve_result
+
+        # Stop session
+        stop_result = await stop_handler.stop_chronolog()
+        assert isinstance(stop_result, str)
+        assert "ChronoLog session stopped" in stop_result
diff --git a/mcps/Chronolog/tests/test_record_handler.py b/mcps/Chronolog/tests/test_record_handler.py
@@ -0,0 +1,53 @@
+"""Tests for Chronolog record interaction capabilities."""
+
+import pytest
+import sys
+import os
+import time
+import random
+
+# Add src to path for testing
+sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
+
+from chronomcp.capabilities.record_handler import record_interaction
+from chronomcp.capabilities.start_handler import start_chronolog
+from chronomcp.capabilities.stop_handler import stop_chronolog
+from .test_utils import are_chronolog_processes_running
+
+
+class TestRecordHandler:
+    """Test record interaction functionality"""
+
+    @pytest.mark.asyncio
+    async def test_record_interaction_basic(self):
+        """Test basic record interaction"""
+        if not are_chronolog_processes_running():
+            pytest.skip("ChronoLog processes are not running")
+
+        chronicle_name = (
+            f"test_chronicle_{int(time.time())}_{random.randint(1000, 9999)}"
+        )
+        story_name = f"test_story_{int(time.time())}_{random.randint(1000, 9999)}"
+
+        # Start session
+        start_result = await start_chronolog(chronicle_name, story_name)
+        assert isinstance(start_result, str)
+        assert "ChronoLog session started" in start_result, (
+            f"Expected session to start, got: {start_result}"
+        )
+
+        # Record interaction
+        result = await record_interaction(
+            "test user message", "test assistant response"
+        )
+        assert isinstance(result, str)
+        assert "Interaction recorded to ChronoLog" in result, (
+            f"Expected interaction to be recorded, got: {result}"
+        )
+
+        # Stop session
+        stop_result = await stop_chronolog()
+        assert isinstance(stop_result, str)
+        assert "ChronoLog session stopped" in stop_result, (
+            f"Expected session to stop, got: {stop_result}"
+        )
diff --git a/mcps/Chronolog/tests/test_retrieve_handler.py b/mcps/Chronolog/tests/test_retrieve_handler.py
diff --git a/mcps/Chronolog/tests/test_start_handler.py b/mcps/Chronolog/tests/test_start_handler.py
diff --git a/mcps/Chronolog/tests/test_stop_handler.py b/mcps/Chronolog/tests/test_stop_handler.py
diff --git a/mcps/Chronolog/tests/test_utils.py b/mcps/Chronolog/tests/test_utils.py
diff --git a/mcps/Chronolog/uv.lock b/mcps/Chronolog/uv.lock
