Skip to content

Fix SdJwtVcPresentationBuilder::conceal #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2025
Merged

Fix SdJwtVcPresentationBuilder::conceal #1713

merged 2 commits into from
Aug 29, 2025

Conversation

UMR1352
Copy link
Contributor

@UMR1352 UMR1352 commented Aug 27, 2025

Description of change

Fixes a bug that made SdJwtVcPresentationBuilder::conceal not working properly.

@UMR1352 UMR1352 requested a review from wulfraem August 27, 2025 11:47
@UMR1352 UMR1352 self-assigned this Aug 27, 2025
@UMR1352 UMR1352 added Bug Something isn't working. Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Aug 27, 2025
wulfraem
wulfraem approved these changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@wulfraem wulfraem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. ^^

Just a small documentation update (that might be helpful in the future) and a just-to-make-sure question. :D

@UMR1352 UMR1352 merged commit 3a2b08d into main Aug 29, 2025
6 checks passed
@UMR1352 UMR1352 deleted the fix/sd-jwt-vc branch August 29, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wulfraem wulfraem wulfraem approved these changes

Assignees

@UMR1352 UMR1352

Labels
Bug Something isn't working. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UMR1352 @wulfraem