fix(ui): after canceling a filter, layer loses its content #8190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug I noticed when testing graphs. This was the sequence of events that triggered the issue:
The issue is related to how the filter module passes the filtered image back to the layer when it's done.
The filtered image is reparented via a konva API, but we did not reset the filter module's reference to the image. Later on, the filter module sees this image in its state and erroneously assumes it owns the image. It does some cleanup and destroys the image, inadvertently destroying it in layer.
The solution is to ensure that when filtering completes, nulls out that reference to the reparented image.
Related Issues / Discussions
QA Instructions
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)