Skip to content

Conversation

@hipsterusername
Copy link
Member

Summary

Fixes the waiting for image screen sticking around after a cancel.

Related Issues / Discussions

N/A

QA Instructions

Cancel an image

Merge Plan

Merge the PR

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Jul 2, 2025
Copy link
Contributor

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will reset the whole staging area when a single item is canceled.

I think the right way to solve this is:

  • Add a computed in invokeai/frontend/web/src/features/controlLayers/components/SimpleSession/context.tsx. It derives a boolean isPending from the $items atom by iterating over them and checking if any are pending/in progress.
  • Add a corresponding boolean flag to CanvasStagingAreaModule.
  • Update CanvasStagingAreaModule.connectToSession to accept this new computed. Add it to the effect and sync the state of hte computed with the corresponding flag in CanvasStagingAreaModule.
  • Use this flag to determine if we should render the placeholder or nothing at all.

@psychedelicious psychedelicious force-pushed the cursor/improve-loading-screen-logic-for-images-bf8d branch from 3f332b3 to 3adb3e2 Compare July 2, 2025 22:01
@psychedelicious psychedelicious force-pushed the cursor/improve-loading-screen-logic-for-images-bf8d branch from 3adb3e2 to 08c2c0e Compare July 2, 2025 22:17
@psychedelicious psychedelicious self-requested a review July 2, 2025 22:17
@psychedelicious psychedelicious merged commit b35f93d into main Jul 3, 2025
12 checks passed
@psychedelicious psychedelicious deleted the cursor/improve-loading-screen-logic-for-images-bf8d branch July 3, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend PRs that change frontend files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants