Exclude default carousel from subject page if subject is associated with a Tag

[jimchamp]

Feature Request

Problem / Opportunity

Proposal

Breakdown

Related files

Refer to this map of common Endpoints:
*

Requirements Checklist

Checklist of requirements that need to be satisfied in order for this issue to be closed:

• [ ]

Stakeholders

---

Instructions for Contributors

• Before creating a new branch or pushing up changes to a PR, please first run these commands to ensure your repository is up to date, as the pre-commit bot may add commits to your PRs upstream.

[Aayushdev18]

I’m interested in implementing this feature. Can I work on it?

[SAYAN02-DEV]

@jimchamp I found the issue, It seems to be in:

openlibrary/openlibrary/templates/subjects.html

Lines 55 to 60 in c507c96

	<div class="contentBody">
	$if has_tag:
	$:format(sanitize(page.tag.body))
	$:macros.QueryCarousel(query=page.solr_query, sort='trending,trending_score_hourly_sum', user_lang_only=True, fallback=True)
	$:macros.PublishingHistory(page.publishing_history)

Here
$:macros.QueryCarousel(query=page.solr_query, sort='trending,trending_score_hourly_sum', user_lang_only=True, fallback=True)

is always displayed, now to implement the requested feature we have to use the has_tag variable to conditionally render the cariusel.

$if has_tag:
      $:format(sanitize(page.tag.body))
    $else:
      $# Only show default carousel if subject doesn't have an associated Tag
      $:macros.QueryCarousel(query=page.solr_query, sort='trending,trending_score_hourly_sum', user_lang_only=True, fallback=True)
    $:macros.PublishingHistory(page.publishing_history)

I made a PR implementing the same can you review it?
https://github.com/internetarchive/openlibrary/pull/11394